Skip to content

Environement files generated twice when changing sourceDir parameter #530

Closed

Description

@maxailloud

Hi there,

After sawing this Pull Request #412 I wanted to give it a try.
So I made a change in my angular-cli-build.js file:

/* global require, module */

var Angular2App = require('angular-cli/lib/broccoli/angular2-app');

module.exports = function(defaults) {
    return new Angular2App(defaults, {
        vendorNpmFiles: [],
        sourceDir: 'src'
  });
};

Just added the sourceDir parameter.

It's working great, now I don't have the client folder that I was useless to me.
But the environement.js file is still copied in the build/client/app folder.
So I end up having 2 environement.js file, in the right folder build/appand in the wrong, that should not exist, folder build/client/app/.

FYI:

Mac OSX El Capitan
angular-cli: 0.0.33
node: 5.0.0
os: darwin x64

Activity

  1. filipesilva commented on Apr 26, 2016

    @filipesilva
    Contributor

    Ah that is entirely my fault. Will fix it asap.

    On Tue, 26 Apr 2016, 11:25 Maxime Ailloud, notifications@github.com wrote:

    Hi there,

    After sawing this Pull Request #412
    #412 I wanted to give it a
    try.
    So I made a change in my angular-cli-build.js file:

    /* global require, module */
    var Angular2App = require('angular-cli/lib/broccoli/angular2-app');
    module.exports = function(defaults) {
    return new Angular2App(defaults, {
    vendorNpmFiles: [],
    sourceDir: 'src'
    });
    };

    Just added the sourceDir parameter.

    It's working great, now I don't have the client folder that I was useless
    to me.
    But the environement.js file is still copied in the build/client/app
    folder.
    So I end up having 2 environement.js file, in the right folder build/appand
    in the wrong, that should not exist, folder build/client/app/.

    FYI:

    Mac OSX El Capitan
    angular-cli: 0.0.33
    node: 5.0.0
    os: darwin x64

    —
    You are receiving this because you are subscribed to this thread.
    Reply to this email directly or view it on GitHub
    #530

  2. maxailloud commented on Apr 26, 2016

    @maxailloud
    Author

    Ok, thank you.

  3. added 2 commits that reference this issue on Apr 26, 2016
    4fb6bfa
    d90a8c2
  4. added a commit that references this issue on Apr 27, 2016
    a6cf825
  5. angular-automatic-lock-bot commented on Sep 5, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  6. locked and limited conversation to collaborators on Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions