Skip to content

chore(commands): Internal command naming could be more consistent #4158

Closed

Description

@catull

OS?

Concerns code style.

Versions.

All versions.

Repro steps.

Not a run-time issue.

The log given by the failure.

Not a run-time issue.

Mention any other details that might be useful.

I'd like to suggest to rename two commands internally:
githubPagesDeployCommand -> GithubPagesDeployCommand
NgCliTestCommand -> TestCommand

I have prepared a PR that does exactly that: #4157

Activity

  1. catull commented on Jan 24, 2017

    @catull
    ContributorAuthor

    PR #4157 was accepted, which makes this issue resolved.

  2. angular-automatic-lock-bot commented on Sep 6, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  3. locked and limited conversation to collaborators on Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions