Skip to content

Double slashes in GitHub pages link on Windows #3810

Closed

Description

@tobymurray

OS?

Windows 10

Versions.

λ ng --version
angular-cli: 1.0.0-beta.24
node: 7.2.1
os: win32 x64
@angular/common: 2.4.1
@angular/compiler: 2.4.1
@angular/core: 2.4.1
@angular/forms: 2.4.1
@angular/http: 2.4.1
@angular/platform-browser: 2.4.1
@angular/platform-browser-dynamic: 2.4.1
@angular/router: 3.4.1
@angular/compiler-cli: 2.4.1

Repro steps.

λ ng new test-app
...
λ cd test-app
λ ng github-pages:deploy
Hash: 2bf0e1245eb5e01382d8
Time: 26858ms
chunk    {0} main.1c717b9fe8fd3d6882ab.bundle.js, main.1c717b9fe8fd3d6882ab.bundle.map (main) 2.91 MB {2} [initial] [rendered]
chunk    {1} styles.87416f5cb43dddfee231.bundle.css, styles.87416f5cb43dddfee231.bundle.map, styles.87416f5cb43dddfee231.bundle.map (styles) 1.69 kB {2} [initial] [rendered]
chunk    {2} inline.f4b4f29a7e700f2413a5.bundle.js, inline.f4b4f29a7e700f2413a5.bundle.map (inline) 0 bytes [entry] [rendered]
Deployed! Visit https://tobymurray.github.io//test-app//
Github pages might take a few minutes to show the deployed site.

The issue here (I believe) is the the double forward slashes in the URL. Very minor, mostly cosmetic as the browser still resolves double slashes appropriately in this case but looks like its unintentional. I tried this out in both Cmder (ConEmu) and Windows Command Prompt and it yielded the same message.

Activity

  1. icepeng commented on Jan 2, 2017

    @icepeng

    Same here

  2. added
    P5The team acknowledges the request but does not plan to address it, it remains open for discussion
    on Jan 24, 2017
  3. filipesilva commented on Feb 3, 2017

    @filipesilva
    Contributor

    Closed via #4385.

  4. angular-automatic-lock-bot commented on Sep 6, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  5. locked and limited conversation to collaborators on Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P5The team acknowledges the request but does not plan to address it, it remains open for discussiontype: bug/fix

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions