github pages deploy create wrong base href for repos with camelcase names #3146

Activity

1. filipesilva

   added

   command: deploy

   P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentAn issue that is relevant to core functions, but does not impede progress. Important, but not urgent

   type: bug/fix

   on Nov 21, 2016
2. rolyatsats commented on Dec 1, 2016

   

   rolyatsats

   on Dec 1, 2016

   Contributor

   More actions

   The ng github-pages:deploy command derives baseHref from packageName, which is pulled from package.json.

   package.json is created through ember-cli/lib/models/blueprint.js which uses the normalizeEntityName function to dasherize as they call it.

   There must be a way to override the normalizeEntityName function to support camelCase.
3. WebDesignerKits commented on Dec 28, 2016

   

   WebDesignerKits

   on Dec 28, 2016

   Last edited by WebDesignerKits

   More actions

   This also creates a problem for github pages that use custom domains.

   In which case the base href needs to default back to just "/" and no longer the name of the repo, or "/some-repo".

   Because unlike the github page, which serves content from: some-account.github.io/some-repo
   A custom domain no longer has the extra file path ie, not this: myWebsite.com/some-repo

   Instead it servers from myWebsite.com, and so it needs a "/" base href.

   Right now the solution is: ng github-pages:deploy --base-href /
4. hansl

   assigned

   filipesilva

   on Jan 9, 2017
5. filipesilva commented on Feb 3, 2017

   

   filipesilva

   on Feb 3, 2017

   Contributor

   More actions

   Closed via #4385.
6. filipesilva

   closed this as completedon Feb 3, 2017
7. angular-automatic-lock-bot commented on Sep 6, 2019

   

   angular-automatic-lock-botBot

   on Sep 6, 2019

   More actions

   This issue has been automatically locked due to inactivity.
   Please file a new issue if you are encountering a similar or related problem.

   Read more about our automatic conversation locking policy.

   _{This action has been performed automatically by a bot.}
8. angular-automatic-lock-bot

   locked and limited conversation to collaborators on Sep 6, 2019