Skip to content

ng destroy does not unlink the dir #304

Closed

Description

@jkuri

When performing ng destroy all related files are unlinked but directory is left in the tree. This is obviously ember-cli issue and we should override that command and unlink the whole related directory.

Activity

  1. Brocco commented on Mar 16, 2016

    @Brocco
    Contributor

    When implementing this fix to prevent execution of ember cli commands that are not relevant to the angular cli please ensure that all commands are accounted for. A graceful message stating that the requested command is not valid would be appropriate.

  2. cwramsey commented on Mar 31, 2016

    @cwramsey
    Contributor

    Is there a list of commands ng will include (unless we're just using all current ones that are listed in the readme) that I can compare to ember-cli?

  3. filipesilva commented on Apr 6, 2016

    @filipesilva
    Contributor

    I think we should try to include the ng destroy command for our blueprints overall. ng g route has to take it into account because removing a route causes side effect (like updating the config).

    The reason ember-cli doesn't automatically destroy the dirs is because they put multiple components/services/etc in each dir.

    With nested routes, we might also have a situation where deleting a route shouldn't delete all files in those directories.

    This feature requires a bit of effort in planning imho.

  4. added
    P5The team acknowledges the request but does not plan to address it, it remains open for discussion
    on Jun 4, 2016
  5. hansl commented on Dec 8, 2016

    @hansl
    Contributor

    Destroy is no longer supported.

  6. angular-automatic-lock-bot commented on Sep 6, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  7. locked and limited conversation to collaborators on Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P5The team acknowledges the request but does not plan to address it, it remains open for discussioneffort2: medium (days)type: bug/fix

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions