Repository navigation
fix: declare ROUTER_PROVIDERS on root component rather than bootstrap #301
Description
According to this style guide it's a best practice to declare the providers on the root component rather than the bootstrap.
According to this style guide it's a best practice to declare the providers on the root component rather than the bootstrap.
Activity
filipesilva commentedon Mar 14, 2016
We're actually waiting for a definite style guide to change all the blueprints to something a little better structured, which is why these providers are still in the bootstrap.
That being said, I won't say no to a PR fixing this bit for now.
cburgdorf commentedon Mar 15, 2016
Ah ok. Feel free to close the PR if you rather like to wait on a definite style guide. I sent the PR as we are teaching people to not maintain providers in the
bootstrapin our thoughtram training. We are soon switching over to use angular-cli in our workshops hence I thought I sent a PR for this change.filipesilva commentedon Mar 16, 2016
Really? That's great news for the CLI!
I hope you come back to the cli repo with a lot of tasty feedback from your trainees :D
angular-automatic-lock-bot commentedon Sep 5, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.