Skip to content

Simplify AoT compilation by ignoring genDir #2849

Closed

Description

@robwormald

Given the AoT plugin no longer writes generated code to disk, allowing a developer to set the genDir for code generation adds a huge amount of complexity to lazy module resolution.

We should simply assume that the generated code ends up in the (virtual) filesystem as a sibling to the original file, and thus resolving for ngfactory code should require simply appending .ngfactory to the path.

Activity

  1. hansl commented on Oct 25, 2016

    @hansl
    Contributor

    I'm going to remove the genDir option to the plugin entirely. There's absolutely no need for it.

  2. added 3 commits that reference this issue on Oct 25, 2016
    dbf2c8f
    797b336
    275333e
  3. added a commit that references this issue on Oct 28, 2016
    0e91dfe
  4. added a commit that references this issue on Feb 9, 2017
    72ea7fd
  5. angular-automatic-lock-bot commented on Sep 6, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  6. locked and limited conversation to collaborators on Sep 6, 2019
  7. added a commit that references this issue on May 29, 2026
    ead8f22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions