Repository navigation
Remove linefeed setting from editor config #2716
Description
OS: Windows 10
Versions:
angular-cli: 1.0.0-beta.15
node: 6.6.0
os: win32 x64
No failure, but the editor config"end_of_line = lf" is annoying for windows if the user has setup git with "core.autocrlf = true", which most people should have done by now. I don't see why the angular-cli project should take a position on this preference, or really any of them. Editorconfig is handy, but including a default one in any cli project can cause grief. I prefer checking out crlf on windows and my editors handle that fine. Having this in editorconfig would work if I set a local repository config for autocrlf=false or input, but then if I happen to use an editor that ignores the editorconfig I would end up committing crlf. It caused some confusion with another team member because every time he did a checkout his editor would tell him all the files he had open have changed.
Activity
filipesilva commentedon Oct 17, 2016
Would you be interested in making a PR to fix this? I'll review it.
chore: fix editorconfig linefeeds on windows
chore: fix editorconfig linefeeds on windows (#2829)
chore: fix editorconfig linefeeds on windows (angular#2829)
chore: fix editorconfig linefeeds on windows (angular#2829)
angular-automatic-lock-bot commentedon Sep 6, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.
chore: fix editorconfig linefeeds on windows (angular#2829)