Skip to content

src/styles.scss compression #2578

Closed
Closed

Description

@MurhafSousli

Hi, I put all my components styles in src/styles.scss where I import other styles in it

@import 'style/vendors/_base';
@import 'style/core/_base';
@import 'style/modules/_base';

I do this to gain access to variables and mixins, but it appears that the CLI doesn't compress it before adding it to the head, is this intended or will it be fixed in the future?

Activity

  1. filipesilva commented on Oct 10, 2016

    @filipesilva
    Contributor

    Hm, can you elaborate on what you mean by this bit?

    the CLI doesn't compress it before adding it to the head

  2. MurhafSousli commented on Oct 10, 2016

    @MurhafSousli
    Author

    @filipesilva I mean the file src/style.scss doesn't get minified, all the styles I use and import are produced without compression
    capture

  3. filipesilva commented on Oct 10, 2016

    @filipesilva
    Contributor

    Got it. Will investigate.

  4. added
    needs: investigationRequires some digging to determine if action is needed
    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
    and removed on Oct 10, 2016
  5. filipesilva commented on Oct 14, 2016

    @filipesilva
    Contributor

    Partially solved by #2593

  6. grizzm0 commented on Oct 17, 2016

    @grizzm0
    Contributor

    The CSS is minified. See the output style.js in your build dir.

    What you're seeing in the head is the CSS from the JS file appended to head by the webpack plugin style-loader. This will be changed in #2646 as "outside of app" styles will compiled to a .css file instead of .js.

    @filipesilva Can be closed.

  7. modified the milestone: on Nov 11, 2016
  8. angular-automatic-lock-bot commented on Sep 6, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  9. locked and limited conversation to collaborators on Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentneeds: investigationRequires some digging to determine if action is neededtype: bug/fix

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions