You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
ng init crashes when using diff on favicon.ico #2274
Repro steps: Run ng init in an Angular-CLI project. At the prompt to (Yndh) the overwriting of favicon.ico enter d to produce a diff of the two files. The CLI will crash.
The log given by the failure. Normally this include a stack trace and some
more information. ? Overwrite src\favicon.ico? Diff value.split is not a function TypeError: value.split is not a function at Object.lineDiff.tokenize (../../src/diff/line.js:7:32) at Object.diff (../../src/diff/base.js:28:39) at diffLines (../../src/diff/line.js:31:71) at structuredPatch (../../src/patch/create.js:8:16) at createTwoFilesPatch (../../src/patch/create.js:98:16) at Object.createPatch (../../src/patch/create.js:122:10) at c:\cndctr\node_modules\angular-cli\lib\models\file-info.js:65:23 at tryCatch (c:\cndctr\node_modules\rsvp\dist\lib\rsvp\-internal.js:215:12) at invokeCallback (c:\cndctr\node_modules\rsvp\dist\lib\rsvp\-internal.js:230:13) at publish (c:\cndctr\node_modules\rsvp\dist\lib\rsvp\-internal.js:198:7) at flush (c:\cndctr\node_modules\rsvp\dist\lib\rsvp\asap.js:82:5) at _combinedTickCallback (internal/process/next_tick.js:67:7) at process._tickCallback (internal/process/next_tick.js:98:9)
Mention any other details that might be useful.
Nothing extra, just a low priority bug that might pop up for some users. Current workaround is just to never diff the favicon.ico file.
Activity
fix(init): ignore favicon
fix(init): ignore favicon
fix(init): ignore favicon
fix(init): ignore favicon
fix(init): ignore favicon
fix(init): ignore favicon
angular-automatic-lock-bot commentedon Sep 6, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.
fix(init): ignore favicon