Skip to content

ng init crashes when using diff on favicon.ico #2274

Closed

Description

@celliott181

Please provide us with the following information:

  1. OS: Windows 10 x64
  2. Versions: Angular-CLI 1.0.0-beta.14, NodeJS 6.5.0
  3. Repro steps: Run ng init in an Angular-CLI project. At the prompt to (Yndh) the overwriting of favicon.ico enter d to produce a diff of the two files. The CLI will crash.
  4. The log given by the failure. Normally this include a stack trace and some
    more information.
    ? Overwrite src\favicon.ico? Diff
    value.split is not a function
    TypeError: value.split is not a function
    at Object.lineDiff.tokenize (../../src/diff/line.js:7:32)
    at Object.diff (../../src/diff/base.js:28:39)
    at diffLines (../../src/diff/line.js:31:71)
    at structuredPatch (../../src/patch/create.js:8:16)
    at createTwoFilesPatch (../../src/patch/create.js:98:16)
    at Object.createPatch (../../src/patch/create.js:122:10)
    at c:\cndctr\node_modules\angular-cli\lib\models\file-info.js:65:23
    at tryCatch (c:\cndctr\node_modules\rsvp\dist\lib\rsvp\-internal.js:215:12)
    at invokeCallback (c:\cndctr\node_modules\rsvp\dist\lib\rsvp\-internal.js:230:13)
    at publish (c:\cndctr\node_modules\rsvp\dist\lib\rsvp\-internal.js:198:7)
    at flush (c:\cndctr\node_modules\rsvp\dist\lib\rsvp\asap.js:82:5)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)
  5. Mention any other details that might be useful.
    Nothing extra, just a low priority bug that might pop up for some users. Current workaround is just to never diff the favicon.ico file.

Activity

  1. added
    P5The team acknowledges the request but does not plan to address it, it remains open for discussion
    on Oct 3, 2016
  2. added 2 commits that reference this issue on Oct 9, 2016
    0d14d84
    5c50477
  3. added a commit that references this issue on Oct 10, 2016
    699ebba
  4. added a commit that references this issue on Oct 14, 2016
    9f164cb
  5. added a commit that references this issue on Oct 19, 2016
    a289a00
  6. added a commit that references this issue on Nov 3, 2016
    b3f4edd
  7. angular-automatic-lock-bot commented on Sep 6, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  8. locked and limited conversation to collaborators on Sep 6, 2019
  9. added a commit that references this issue on May 29, 2026
    a06567c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P5The team acknowledges the request but does not plan to address it, it remains open for discussion

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions