Repository navigation
Cannot read property 'notifications' of undefined #214
Description
If the package.json file doesn't have an "angular-cli" field, calls to ng build will fail with the following error:
TypeError: [DiffingTSCompiler]: Cannot read property 'notifications' of undefined
at DiffingTSCompiler.showNotification (..../node_modules/angular-cli/lib/broccoli/broccoli-typescript.js:196:38)
Activity
filipesilva commentedon Feb 18, 2016
I believe this should be "fixed" in the latest master. By fixed though, I mean the notification functionality should be inadvertently gone and thus the notification check does not happen anymore.
@hansl can you chime in? I'm following info from #134 (comment) together with #206
danwkennedy commentedon Feb 18, 2016
I found this on the latest master as of yesterday morning. I can try again on a later commit in a bit. The work around obviously is to add that option in package so it hasn't blocked me or anything
filipesilva commentedon Feb 18, 2016
#206 happened 16h ago, I think that is when it changed.
danwkennedy commentedon Feb 18, 2016
Looks like it's fixed in 0.0.20 👍
hansl commentedon Feb 18, 2016
@filipesilva: Yes, it was fixed. This is a non-issue for now :)
filipesilva commentedon Feb 18, 2016
@hansl If it is indeed removed, then the rest of the changes introduced in the original PR should also be removed.
hansl commentedon Feb 18, 2016
Agreed. If you don't have time for that I can do it.
chore(notifications): revert remaining files
fix(@angular-devkit/build-optimizer): fix hoisted class declarations
fix(@angular-devkit/build-optimizer): fix hoisted class declarations
angular-automatic-lock-bot commentedon Sep 5, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.