Skip to content

Remove typings.d.ts #1604

Closed
Closed

Description

@hansl

Its content is only needed for test, so let's move those declaration in test.ts.

Activity

  1. TheLarkInn commented on Aug 10, 2016

    @TheLarkInn
    Member

    Can we still keep the require() which is needed for the angular2-template-loader to be ambiently defined. Or is this just in regards to the System, and moduledefinitions.

  2. hansl commented on Aug 10, 2016

    @hansl
    ContributorAuthor

    Do you run angular2-template-loader before the typescript compilation?

  3. TheLarkInn commented on Aug 10, 2016

    @TheLarkInn
    Member

    Yes it does, it modifies the ts file prior to.

  4. mbeckenbach commented on Oct 21, 2016

    @mbeckenbach

    Are you sure, that you want to remove it? There are still sometimes cases where you have to manually write some definitions for external libraries that don't have one

  5. filipesilva commented on Oct 21, 2016

    @filipesilva
    Contributor

    Fixed by #2714. Didn't remove the file but updated the comments.

    https://github.com/angular/angular-cli#3rd-party-library-installation also references this file for typeless libs.

  6. angular-automatic-lock-bot commented on Sep 6, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  7. locked and limited conversation to collaborators on Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions