Skip to content

value.split is not a function #1286

Closed
Closed

Description

@scrivy
  1. Mac OSX El Capitan 10.11.5
  2. angular-cli: 1.0.0-beta.9, node: 4.4.6, os: darwin x64
  3. Repro steps.

Run ng init to upgrade from angular-cli 1.0.0-beta.7 to beta.9, when asked to Overwrite src/favicon.ico? try to diff

? Overwrite src/favicon.ico? Diff
value.split is not a function
TypeError: value.split is not a function
at Object.lineDiff.tokenize (/srv/fuma/frontend/node_modules/angular-cli/node_modules/diff/lib/diff/line.js:22:32)
at Object.diff (/srv/fuma/frontend/node_modules/angular-cli/node_modules/diff/lib/diff/base.js:36:39)
at diffLines (/srv/fuma/frontend/node_modules/angular-cli/node_modules/diff/lib/diff/line.js:47:19)
at structuredPatch (/srv/fuma/frontend/node_modules/angular-cli/node_modules/diff/lib/patch/create.js:18:83)
at createTwoFilesPatch (/srv/fuma/frontend/node_modules/angular-cli/node_modules/diff/lib/patch/create.js:131:14)
at Object.createPatch (/srv/fuma/frontend/node_modules/angular-cli/node_modules/diff/lib/patch/create.js:151:10)
at /srv/fuma/frontend/node_modules/angular-cli/node_modules/angular-cli/lib/models/file-info.js:65:23
at lib$rsvp$$internal$$tryCatch (/srv/fuma/frontend/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:1036:16)
at lib$rsvp$$internal$$invokeCallback (/srv/fuma/frontend/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:1048:17)
at lib$rsvp$$internal$$publish (/srv/fuma/frontend/node_modules/angular-cli/node_modules/rsvp/dist/rsvp.js:1019:11)

Activity

  1. filipesilva commented on Jul 28, 2016

    @filipesilva
    Contributor

    That's a bug that I don't think we can fix right now. The ng init command on the version of ember-cli we use fails when diffing images.

  2. added
    P5The team acknowledges the request but does not plan to address it, it remains open for discussion
    on Jul 28, 2016
  3. dzonatan commented on Oct 24, 2016

    @dzonatan
    Contributor

    I think this is fixed by #2617 and can be closed.

  4. filipesilva commented on Nov 2, 2016

    @filipesilva
    Contributor

    @dzonatan is most correct, thanks!

  5. angular-automatic-lock-bot commented on Sep 6, 2019

    @angular-automatic-lock-bot

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    This action has been performed automatically by a bot.

  6. locked and limited conversation to collaborators on Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P5The team acknowledges the request but does not plan to address it, it remains open for discussiontype: bug/fix

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions