Generated directive class name should have 'Directive' suffix

Version

$ ng --version
(node:20286) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://ember-cli.com/user-guide/#watchman for more info.
angular-cli: 1.0.0-beta.6
node: 6.2.1
os: linux x64

Repro steps

The following generate command produces a directive class name without the 'Directive' suffix.

$ ng g directive shared/directives/wrap-if
(node:20210) fs: re-evaluating native module sources is not supported. If you are using the graceful-fs module, please update it to a more recent version.
Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://ember-cli.com/user-guide/#watchman for more info.
installing directive
  create src/app/shared/directives/wrap-if.directive.spec.ts
  create src/app/shared/directives/wrap-if.directive.ts

src/app/shared/directives/wrap-if.directive.ts

import { Directive } from '@angular/core';

@Directive({
  selector: '[wrap-if]'
})
export class WrapIf {

  constructor() {}

}

As per the styleguide,

Do append the symbol name with the suffix that it represents.
...
export class ValidationDirective

The generated class name should be WrapIfDirective.

@Brocco

@Brocco could you have a look please?

bug(directive): update directive class name to match style guide

bug(directive): update directive class name to match style guide (#1750)

The associated spec file of the directive still imports the wrong directive name:

/* tslint:disable:no-unused-variable */

import { TestBed, async } from '@angular/core/testing';
import { HoverEvent } from './hover-event.directive';

describe('Directive: HoverEvent', () => {
  it('should create an instance', () => {
    let directive = new HoverEventDirective();
    expect(directive).toBeTruthy();
  });
});

Is this better suited to a new issue or can this one be re-opened?

What version are you using? ng version

$ ng version
Could not start watchman; falling back to NodeWatcher for file system events.
Visit http://ember-cli.com/user-guide/#watchman for more info.
angular-cli: 1.0.0-beta.15
node: 6.2.1
os: linux x64

@Brocco

Okay I'll reopen this and assign it to @Brocco.

This has been resolved via PR #1940 and will be included in the next release

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

Navigation Menu

Repository navigation

Generated directive class name should have 'Directive' suffix #1217

Version

Repro steps

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Generated directive class name should have 'Directive' suffix #1217

Description

Version

Repro steps

Activity

filipesilva commented on Aug 19, 2016

Blasz commented on Sep 22, 2016

hansl commented on Sep 22, 2016

Blasz commented on Sep 22, 2016

hansl commented on Sep 22, 2016

Brocco commented on Sep 24, 2016

angular-automatic-lock-bot commented on Sep 6, 2019

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions