Repository navigation
Webapp Manifest icons are generated with invalid paths #1179
Description
- Mac OS-X El Capitan
- Versions.
angular-cli: 1.0.0-beta.6
node: 4.4.3
os: darwin x64 - Repro steps.
ng new myApp --mobile - The log given by the failure.
N/A. - Mention any other details that might be useful.
The icon section of the manifest currently generated by the angular-cli looks like this:
"icons": [
{
"src": "/android-chrome-36x36.png",
"sizes": "36x36",
"type": "image/png",
"density": 0.75
},
{
"src": "/android-chrome-48x48.png",
"sizes": "48x48",
"type": "image/png",
"density": 1
},
{
"src": "/android-chrome-72x72.png",
"sizes": "72x72",
"type": "image/png",
"density": 1.5
},
{
"src": "/android-chrome-96x96.png",
"sizes": "96x96",
"type": "image/png",
"density": 2
},
{
"src": "/android-chrome-144x144.png",
"sizes": "144x144",
"type": "image/png",
"density": 3
},
{
"src": "/android-chrome-192x192.png",
"sizes": "192x192",
"type": "image/png",
"density": 4
}
],
This doesn't work since the icons are bundled into dist/icons and not just in dist/. To fix this, it needs to define the icon src like this:
"icons": [
{
"src": "icons/android-chrome-36x36.png",
"sizes": "36x36",
"type": "image/png"
},
{
"src": "icons/android-chrome-48x48.png",
"sizes": "48x48",
"type": "image/png"
},
{
"src": "icons/android-chrome-72x72.png",
"sizes": "72x72",
"type": "image/png"
},
{
"src": "icons/android-chrome-96x96.png",
"sizes": "96x96",
"type": "image/png"
},
{
"src": "icons/android-chrome-144x144.png",
"sizes": "144x144",
"type": "image/png"
},
{
"src": "icons/android-chrome-192x192.png",
"sizes": "192x192",
"type": "image/png"
}
],
Activity
fix(mobile): add `icons/` path in front of icon `src` values
fix(mobile): add `icons/` path in front of icon `src` values
fix(mobile): add `icons/` path in front of icon `src` values
fix(mobile): 'Add to Homescreen' on mobile does not find icons
fix(mobile): add `icons/` path in front of icon `src` values
fix(mobile): add `icons/` path in front of icon `src` values
angular-automatic-lock-bot commentedon Sep 6, 2019
This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.