ng build -prod fails to clean up files #1068

Activity

1. lamaan commented on Jun 12, 2016

   

   lamaan

   on Jun 12, 2016

   Author

   More actions

   this was just windows not deleting files correctly and some other config errors which have now been resolved
2. lamaan

   closed this as completedon Jun 12, 2016
3. SijanC147 commented on Jun 15, 2016

   

   SijanC147

   on Jun 15, 2016

   More actions

   I know this is closed but I'm facing the very same issue and was wondering how did you resolve this?
4. lamaan commented on Jun 15, 2016

   

   lamaan

   on Jun 15, 2016

   Author

   More actions

   Just had to delete the tmp folder manually. Initially, it was quite large. But now, I rarely get the problem.

   -----Original Message-----
   From: "Sean" notifications@github.com
   Sent: ‎15/‎06/‎2016 06:46
   To: "angular/angular-cli" angular-cli@noreply.github.com
   Cc: "lamaan" lamaan@lamaan.com; "State change" state_change@noreply.github.com
   Subject: Re: [angular/angular-cli] ng build -prod fails to clean up files (#1068)

   I know this is closed but I'm facing the very same issue and was wondering how did you resolve this?

   ---

   You are receiving this because you modified the open/close state.
   Reply to this email directly or view it on GitHub:
   #1068 (comment)
5. NgxDev commented on Jul 29, 2016

   

   NgxDev

   on Jul 29, 2016

   Last edited by NgxDev

   More actions

   angular-cli version: 1.0.0-beta.10

   I still get the error. But here's what's causing it for me:

   In my "app" folder I have a "+static" folder, in which I've created an index.ts (as the styleguide recommends):

   export * from './contact';
   export * from './privacy';
   export * from './support';
   export * from './terms-and-conditions';
   

   In the same "+static" folder, I have all the necessary components, each in it's own folder: contact, privacy etc. Each of these folders also has an index.ts with export * from './name-of.component';

   Then, in my app.routes.ts I have:

   import {
       ContactComponent,
       PrivacyComponent,
       SupportComponent,
       TermsAndConditionsComponent
   } from './+static';
   

   and, in my system-config.ts I have the following barrels (created automatically by the cli):

   const barrels: string[] = [
       // ...
       'app/+static/contact',
       'app/+static/privacy',
       'app/+static/support',
       'app/+static/terms-and-conditions'
   ]
   

   Tried the following:

   1. In my system-config.ts, instead of all those barrels, just put app/+static. Doesn't work.
   2. In my app.routes.ts, instead of the import { .. } from './+static'; I've actually wrote an import for each component (import { ContactComponent } from './+static/contact';. This works, I don't get the error anymore. But this means the index.ts in my +static folder is useless. And, as far as I know, the styleguide recommends the use of an index.ts specifically to have less import statements (like I was trying, to import { Component1, Component2, Component3 ... } from './+static';
      So, I'm wondering... If they recommend it, it should work... But it doesn't work. Am I doing something wrong? Or is it a bug? And I should open one accordingly, with the exact scenario I have?
6. filipesilva commented on Jul 29, 2016

   

   filipesilva

   on Jul 29, 2016

   Contributor

   More actions

   @MrCroft I can't say one way or another if it's a build bug or a code bug, but since we're moving away from SystemJS config in #1455 it might be a good idea to try that before opening an issue. There's no release yet though.
7. NgxDev commented on Jul 29, 2016

   

   NgxDev

   on Jul 29, 2016

   Last edited by NgxDev

   More actions

   @filipesilva
   Oh, I'm so sad! I was so avoiding webpack :)
   Then again, I've got to hating webpack so so much simply because more and more examples out there were using it, going "against" the default (systemjs) approach of the cli, which is also the default approach in the angular docs/quickstart.
   Now I'm wondering if it will be a quick and painless transition, to move my cli app from systemjs to webpack, once the cli will move away from systemjs and towards webpack.
8. filipesilva commented on Jul 29, 2016

   

   filipesilva

   on Jul 29, 2016

   Contributor

   More actions

   I've WIP instructions in #1456. Most people seem to think the transition is easy.

   👍React with 👍1Reacted by Marian Stoica
9. lamaan commented on Aug 5, 2016

   

   lamaan

   on Aug 5, 2016

   Author

   More actions

   Hi,

   I have now moved the code to the webpack version and am getting the following curious error from webpack trying to resolve a different dependency injection issue:

   It seems that the Provider is not the correct type of provider?

   https://github.com/lamaan/angular2-salah-times/tree/dictionary-with-injected-routes https://github.com/lamaan/angular2-salah-times/tree/dictionary-with-injected-routes

   Lamaan

   From: Filipe Silva [mailto:notifications@github.com]
   Sent: 29 July 2016 18:29
   To: angular/angular-cli angular-cli@noreply.github.com
   Cc: lamaan lamaan@lamaan.com; State change state_change@noreply.github.com
   Subject: Re: [angular/angular-cli] ng build -prod fails to clean up files (#1068)

   I've WIP instructions in #1456 #1456 . Most people seem to think the transition is easy.

   —
   You are receiving this because you modified the open/close state.
   Reply to this email directly, view it on GitHub #1068 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AFcXknye6JGMmFwaPg4Nn9Z3zwYmpKf3ks5qahxQgaJpZM4IzxAR . https://github.com/notifications/beacon/AFcXkhKtWQNTYaQ_PJR9-PcrXfym41FQks5qahxQgaJpZM4IzxAR.gif
10. lamaan commented on Aug 6, 2016

    

    lamaan

    on Aug 6, 2016

    Author

    More actions

    Hi again,

    I removed the dependency on angular2-google-maps to get it working.

    Other problems found using web pack:

    1.  Files are very big. It creates 5Mb main script file and 5 Mb map file. Which is very large for a small app like this.
       

    2.  The source map cannot be parsed – at least by chrome which makes debugging only possible really with console.log.
       

    3.  I cannot see how to include additional npm components as I did with system.js packages – so for now I have managed with using cdn. 
       

    Please can you let me know if and when you have any solutions to these?

    Lamaan

    From: Lamaan Ball [mailto:lamaan@lamaan.com]
    Sent: 05 August 2016 07:39
    To: 'angular/angular-cli' reply@reply.github.com
    Subject: RE: [angular/angular-cli] ng build -prod fails to clean up files (#1068)

    Hi,

    I have now moved the code to the webpack version and am getting the following curious error from webpack trying to resolve a different dependency injection issue:

    It seems that the Provider is not the correct type of provider?

    https://github.com/lamaan/angular2-salah-times/tree/dictionary-with-injected-routes https://github.com/lamaan/angular2-salah-times/tree/dictionary-with-injected-routes

    Lamaan

    From: Filipe Silva [mailto:notifications@github.com]
    Sent: 29 July 2016 18:29
    To: angular/angular-cli <angular-cli@noreply.github.com mailto:angular-cli@noreply.github.com >
    Cc: lamaan <lamaan@lamaan.com mailto:lamaan@lamaan.com >; State change <state_change@noreply.github.com mailto:state_change@noreply.github.com >
    Subject: Re: [angular/angular-cli] ng build -prod fails to clean up files (#1068)

    I've WIP instructions in #1456 #1456 . Most people seem to think the transition is easy.

    —
    You are receiving this because you modified the open/close state.
    Reply to this email directly, view it on GitHub #1068 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AFcXknye6JGMmFwaPg4Nn9Z3zwYmpKf3ks5qahxQgaJpZM4IzxAR . https://github.com/notifications/beacon/AFcXkhKtWQNTYaQ_PJR9-PcrXfym41FQks5qahxQgaJpZM4IzxAR.gif
11. filipesilva commented on Aug 15, 2016

    

    filipesilva

    on Aug 15, 2016

    Contributor

    More actions

    @lamaan can you open a new issue for the issue you're still experiencing?
12. angular-automatic-lock-bot commented on Sep 6, 2019

    

    angular-automatic-lock-botbot

    on Sep 6, 2019

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
13. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 6, 2019