Feature Request : ng build to include a --base-href <base> #1064

Activity

1. filipesilva

   added

   featureLabel used to distinguish feature request from other issuesLabel used to distinguish feature request from other issues

   P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentAn issue that is relevant to core functions, but does not impede progress. Important, but not urgent

   effort1: easy (hours)

   on Jun 18, 2016
2. filipesilva

   added

   P1Impacts a large percentage of users; if a workaround exists it is partial or overly painfulImpacts a large percentage of users; if a workaround exists it is partial or overly painful

   and removed

   P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgentAn issue that is relevant to core functions, but does not impede progress. Important, but not urgent

   on Jul 28, 2016
3. dzonatan

   added a commit that references this issue on Jul 29, 2016

   feat: implement --base-href argument

   ...

   This issue will close once commit 9ab6587 is merged into the 'master' branch.

   9ab6587
4. dzonatan commented on Jul 29, 2016

   

   dzonatan

   on Jul 29, 2016

   Last edited by dzonatan

   Contributor

   More actions

   I've started and actually did some work on this because I missed it in webpack version.. and I really need it. :|

   To make sure I'm in the right way I need someone of angular members approval about how this argument should work.
   Is it good for you to have such case scenarios:

   • if no --base-href tag provided then do nothing (keep the template index.html untouched). In such case the user is able to use base tag purely. This also ensures to don't have any breaking changes.
   • if --base-href x provided and base tag doesn't exists then insert <base href="x"> in header.
   • if --base-href x provided and base tag already exists then replace only the "href" attribute of base tag. (In case developer uses additional attribute(s) like "target").

   Also I'm thinking that instead of auto-prefixing url with slash whole url should be provided by developer for the case when I want to overwrite my /xxx/ (which already sits in index.html) with just /.
5. filipesilva commented on Jul 29, 2016

   

   filipesilva

   on Jul 29, 2016

   Contributor

   More actions

   I was gonna pick this one up, but if you're working on it I'm happy to help. I'm speaking as myself now, design for this feature hasn't been discussed within the team.

   There's a couple of extra things you have to look into when developing this feature:

   • needs to be tested
   • the github deploy feature already does a regex base replacement, so it needs to be changed to use this feature
   • needs to conform to router best practices found in https://angular.io/docs/ts/latest/guide/router.html

   As far as behavior goes, I think your proposal makes sense. I also agree the developer should provide the whole URL.
6. dzonatan

   added 11 commits that reference this issue on Jul 29, 2016

   feat: implement --base-href argument

   ...

   This issue will close once commit 26f5d98 is merged into the 'master' branch.

   26f5d98

   feat: implement --base-href argument

   ...

   This issue will close once commit 2bf62f1 is merged into the 'master' branch.

   2bf62f1

   feat: implement --base-href argument

   ...

   This issue will close once commit f3f101b is merged into the 'master' branch.

   f3f101b

   feat: implement --base-href argument

   ...

   This issue will close once commit 95353cc is merged into the 'master' branch.

   95353cc

   feat: implement --base-href argument

   ...

   This issue will close once commit a58458e is merged into the 'master' branch.

   a58458e

   feat: implement --base-href argument

   ...

   This issue will close once commit 4723ea4 is merged into the 'master' branch.

   4723ea4

   feat: implement --base-href argument

   ...

   This issue will close once commit a89cde0 is merged into the 'master' branch.

   a89cde0

   feat: implement --base-href argument

   ...

   This issue will close once commit 87fcc88 is merged into the 'master' branch.

   87fcc88

   feat: implement --base-href argument

   ...

   This issue will close once commit cf94397 is merged into the 'master' branch.

   cf94397

   feat: implement --base-href argument

   ...

   This issue will close once commit ea99974 is merged into the 'master' branch.

   ea99974

   feat: implement --base-href argument

   ...

   This issue will close once commit f9e08c7 is merged into the 'master' branch.

   f9e08c7
7. dzonatan

   added a commit that references this issue on Aug 9, 2016

   feat: implement --base-href argument

   ...

   This issue will close once commit b216b06 is merged into the 'master' branch.

   b216b06
8. dzonatan

   added 4 commits that reference this issue on Aug 23, 2016

   feat: implement --base-href argument

   ...

   This issue will close once commit 35413c6 is merged into the 'master' branch.

   35413c6

   feat: implement --base-href argument

   ...

   This issue will close once commit 8dd2cfe is merged into the 'master' branch.

   8dd2cfe

   feat: implement --base-href argument

   ...

   This issue will close once commit d494f64 is merged into the 'master' branch.

   d494f64

   feat: implement --base-href argument

   ...

   This issue will close once commit e6dc4c9 is merged into the 'master' branch.

   e6dc4c9
9. filipesilva

   added a commit that references this issue on Aug 26, 2016

   feat(build): implement --base-href argument

   ...

   This issue will close once commit 74b29b3 is merged into the 'master' branch.

   74b29b3
10. filipesilva

    closed this as completedin 74b29b3on Aug 26, 2016
11. isleshocky77 commented on Nov 28, 2016

    

    isleshocky77

    on Nov 28, 2016

    More actions

    @dzonatan I'm not seeing it anywhere in the commit, but are you able to configure this option in the environment files instead?

    👍React with 👍20Reacted by Alex Ryckman Mellnik, Adam, Stefan Feilmeier, jose am, Patrick Hütter, Kim Kern, OlegK, juliormm, Chris Marx, Hallyson Almeida and 10 more
12. angular-automatic-lock-bot commented on Sep 6, 2019

    

    angular-automatic-lock-botBot

    on Sep 6, 2019

    More actions

    This issue has been automatically locked due to inactivity.
    Please file a new issue if you are encountering a similar or related problem.

    Read more about our automatic conversation locking policy.

    _{This action has been performed automatically by a bot.}
13. angular-automatic-lock-bot

    locked and limited conversation to collaborators on Sep 6, 2019