Wire sync's -project flag to actually project onto the board - #165
Merged
Merged
Conversation
Deploying specsync with
|
| Latest commit: |
9325fa5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8a658858.specsync.pages.dev |
| Branch Preview URL: | https://feat-159-wire-sync-board-pro.specsync.pages.dev |
Sync's per-provider loop pushed the issue but never called ProjectOntoBoard, so -project (and openspec/specsync.yml's board target) reported BoardConfigured: true while silently doing nothing to the board. Restores the call, mirroring pull.go's existing usage, and reports the plan through ItemResult.Board so -dry-run finally previews it. A projection error is now a non-fatal stderr warning instead of being swallowed.
androidand
force-pushed
the
feat/159-wire-sync-board-projection
branch
from
September 17, 2026 14:29
804b3d6 to
9325fa5
Compare
androidand
added a commit
that referenced
this pull request
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sync's per-provider loop pushed the issue but never calledProjectOntoBoard, sosync -project(andopenspec/specsync.yml's board target) reportedBoardConfigured: trueand silently did nothing to the board — a regression from the fan-out refactor (4177dc7).pull.go's existing usage exactly, and threads the resulting plan throughItemResult.Boardso-dry-runfinally previews it (add/status/assignee lines) instead of printing a static, always-true "would ensure the issue is on the board" line.ProjectOntoBoardfailure is now a non-fatal warning on stderr instead of being silently possible to swallow — matches the failure mode this proposal exists to remove.TestPull_CannotResolveFromBranchrelied on whatever branch the suite happened to be run from instead of overridingcurrentBranchFnlike every other branch-resolution test — it failed whenever run from afeat/<n>-<slug>-named branch (i.e. this one).Closes #159
Test plan
go build ./...,go vet ./...go test ./...— 788 passed, 0 failedTestSyncProjectsOntoBoardWhenConfigured) verified to fail without the fix (0 calls) and pass with it-dry-runstill previewsandroidand/2): unpatched binary prints only the static bullet withStatus/assignee always empty; patched binary prints the real plan (add/status/assignee) — matches the exact silent-no-op described in the proposalspecsync changelog -resolve-refsrenders this commit under "Fixed" via the proposal's Release Notes section