Skip to content

optimisation coded, but not used  #23

Open

Description

@silviatoonen

The Makefiles of SeBa include the optimisation flag -O through CFLAGS += -O
However CFLAGS is not used.

My suggestion: add a flag: CXXFLAGS += -O (or -O2)

Any objections of why not to do this?

Activity

  1. silviatoonen commented on Sep 11, 2023

    @silviatoonen
    CollaboratorAuthor

    credit to Evert!

  2. silviatoonen commented on Sep 11, 2023

    @silviatoonen
    CollaboratorAuthor

    from some preliminary tests, using the optimisation flags speeds up SeBa by a factor 2-3.

  3. rieder commented on Sep 11, 2023

    @rieder
    Member
  4. silviatoonen commented on Sep 13, 2023

    @silviatoonen
    CollaboratorAuthor

    It would be for both.
    It seems that this optimisation was intended to be included, but for some time it has not been the case.

    @spzwart do you remember if for some reason it was switched of? otherwise I'll switch it back on. A factor 2-3 improvement is always nice.

  5. spzwart commented on Sep 14, 2023

    @spzwart
    Contributor

    Yes, I think that we had done problems with the convergence in teaching RLOF. but lets them out back on, and test the code, see what happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions