Claude/search index utility 5ekh4q

[amirbiron]

תבנית Pull Request

✨ תיאור קצר

• מה שיניתם ולמה? (2-3 משפטים)

📦 שינויים עיקריים

• קוד (Backend)
• בוט טלגרם
• מסד נתונים/מיגרציות
• תיעוד (docs/)
• DevOps/CI/CD

פירוט נקודות (רשימת תבליטים):

🧪 בדיקות

• איך בדקתם? מה עבר? מה נשאר?
• Unit
• Integration
• Manual

🧪 בדיקות נדרשות ב‑PR

• 🔍 Code Quality & Security
• Unit Tests (3.11)
• Unit Tests (3.12)

📝 סוג שינוי

• feat: פיצ'ר חדש
• fix: תיקון באג
• docs: שינוי תיעוד בלבד
• refactor: שינוי קוד ללא שינוי התנהגות
• perf: שיפור ביצועים
• chore/ci: תשתית/CI
• breaking change: שינוי שובר תאימות

דוגמאות Conventional Commits

סוג	דוגמה להודעה	מתי להשתמש
feat	feat: הוספת מסך הגדרות	פיצ'ר חדש למשתמש
fix	fix: תיקון קריסה בעת התחברות	תיקון באג מול משתמשים/פרודקשן
chore	chore: שדרוג Gradle ל-8.9	תחזוקה, כלי פיתוח, housekeeping
docs	docs: עדכון README עם הוראות התקנה	שינויי תיעוד בלבד
refactor	refactor: חילוץ Repository ל-UseCases	שינוי מבני ללא שינוי התנהגות
test	test: הוספת בדיקות ל-LoginViewModel	הוספת/עדכון בדיקות
build	build: הוספת flavor staging ל-CI	שינויים בבילד/תלויות/תצורה

✅ צ'קליסט

• הקוד עוקב אחרי הסגנון (Black/isort/flake8/mypy)
• בדיקות רצות ועוברות
• תיעוד עודכן (README/Docs)
• אם נוספו ג'ובים חדשים (Background Jobs) – וודא שהם רשומים ב-services/register_jobs.py (כולל Callback/Trigger להפעלה ידנית — למשל callback_name/trigger_func לפי המבנה) כדי שיופיעו בדשבורד
• אם נוספו/שונו משתני סביבה – עודכן docs/environment-variables.rst וגם services/config_inspector_service.py
• אם נוספו/השתנו טוקנים – עודכן גם docs/webapp/theming_and_css.rst + FEATURE_SUGGESTIONS/theme_matrix.md
• אין סודות/מפתחות בקוד
• אין מחיקות מסוכנות/פעולות על root (ראו .cursorrules)
• הודעת הקומיט תואמת Conventional Commits (ע"פ הטבלה)
• CHANGELOG עודכן אם נדרש
• כל ה‑Required Checks לעיל ירוקים
• צילום/וידאו UI מצורף אם רלוונטי
• עיינתי במסמכי אתר התיעוד — נתיב: ______ | המשפט: "______"
• לא נדרש עיון — התנאי לא התקיים כי: ______

🧩 השפעות/סיכונים

• השפעה אפשרית על פרודקשן, ביצועים, או אבטחה:

🔗 קישורים

• Issues קשורים: #
• Docs Preview:
• מסמכים/מפרטים רלוונטיים:
• Branch Protection & PR Rules

🧯 סיכון / החזרה לאחור (Rollback)

• תוכנית חזרה לאחור במקרה תקלה:

Summary by Sourcery

Bug Fixes:

• Ensure global search autocomplete and language menus render above adjacent search cards.

[qodo-code-review]

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

[sourcery-ai]

Sorry @amirbiron, you've used your own review budget of 250,000 diff characters for the last 7 days.

You can request another review in 3 hours and 33 minutes by commenting @sourcery-ai review. Upgrade to get a review now.

[coderabbitai]

Warning

Review limit reached

Next included review available in 15 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: a1f72098-a3ea-4533-b07d-11239e3dad58

📥 Commits

Reviewing files that changed from the base of the PR and between 86ade33 and 22f7838.

📒 Files selected for processing (1)

• webapp/static/css/global_search.css

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🧯 Dangerous deletes guard report

Policy: see .cursorrules — dangerous deletions are blocked unless wrapped safely.

Summary:

• Flagged findings (blocking): 0
  0
• Excluded matches (not blocking): 15
• Total matches (all files): 129

Flagged findings (file:line:snippet):
(none)

Excluded matches (by path pattern)

./webapp/static/js/md_preview.bundle.js.map:4:  "sourcesContent": ["// Markdown-it plugin to render GitHub-style task lists; see\n//\n// https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments\n// https://github.com/blog/1825-t … [truncated]
./docs/DOCUMENTATION_GUIDE.md:453:rm -rf _build
./docs/Makefile:24:	rm -rf $(BUILDDIR)
./Dockerfile:42:    rm -rf /var/lib/apt/lists/*
./Dockerfile:121:    rm -rf /var/lib/apt/lists/*
./node_modules/katex/package.json:153:    "build": "rimraf dist/ && mkdirp dist && cp README.md dist && rollup -c --failAfterWarnings && webpack && node update-sri.js package dist/README.md",
./node_modules/katex/src/fonts/Makefile:139:	rm -rf pfa ff otf ttf woff woff2
./node_modules/mermaid/dist/mermaid.js.map:4:  "sourcesContent": ["/**\n* Default values for dimensions\n*/\nconst defaultIconDimensions = Object.freeze({\n\tleft: 0,\n\ttop: 0,\n\twidth: 16,\n\theight: 16\n});\n/**\n* Default values for tr … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.esm/chunk-2M32CCKP.mjs.map:4:  "sourcesContent": ["{\n  \"name\": \"mermaid\",\n  \"version\": \"11.12.0\",\n  \"description\": \"Markdown-ish syntax for generating flowcharts, mindmaps, sequence d … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.esm.min/chunk-4HFYJGYH.mjs.map:4:  "sourcesContent": ["{\n  \"name\": \"mermaid\",\n  \"version\": \"11.12.0\",\n  \"description\": \"Markdown-ish syntax for generating flowcharts, mindmaps, sequen … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.esm.min/chunk-4HFYJGYH.mjs:1:var r={name:"mermaid",version:"11.12.0",description:"Markdown-ish syntax for generating flowcharts, mindmaps, sequence diagrams, class diagrams, gantt charts, git graph … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.core/chunk-KS23V3DP.mjs.map:4:  "sourcesContent": ["{\n  \"name\": \"mermaid\",\n  \"version\": \"11.12.0\",\n  \"description\": \"Markdown-ish syntax for generating flowcharts, mindmaps, sequence  … [truncated]
./node_modules/mermaid/dist/mermaid.min.js:1524:`,"getStyles"),c1e=RQe});var h1e={};dr(h1e,{diagram:()=>NQe});var NQe,f1e=N(()=>{"use strict";$ge();a1e();l1e();u1e();NQe={parser:Fge,db:n1e,renderer:o1e,styles:c1e}});var m1e,g1e=N(()=>{"use  … [truncated]
./node_modules/mermaid/dist/mermaid.min.js.map:4:  "sourcesContent": ["/**\n* Default values for dimensions\n*/\nconst defaultIconDimensions = Object.freeze({\n\tleft: 0,\n\ttop: 0,\n\twidth: 16,\n\theight: 16\n});\n/**\n* Default values fo … [truncated]
./README.md:842:find . -name "__pycache__" -exec rm -rf {} +

[sourcery-ai]

Reviewer's Guide

The PR optimizes search by avoiding unnecessary in-memory index builds, adds configuration controls and regression coverage for index behavior and mutation, and redesigns WebApp autocomplete suggestions for correct positioning, theming, accessibility, and overflow handling.

Sequence diagram for lazy search index building

sequenceDiagram
    participant Caller
    participant SearchEngine
    participant SearchIndex
    participant MongoDB

    Caller->>SearchEngine: search(user_id, query, search_type)
    alt TEXT or FUNCTION
        SearchEngine->>SearchIndex: _get_index_for_search(user_id)
        alt index enabled
            SearchIndex->>SearchIndex: get_index(user_id)
            SearchIndex->>MongoDB: rebuild_index(user_id) when missing or stale
            SearchIndex-->>SearchEngine: ready index
            SearchEngine->>SearchIndex: _text_search or _function_search
        else index disabled
            SearchIndex-->>SearchEngine: empty SearchIndex
            SearchEngine->>MongoDB: $text fallback for TEXT
        end
    else CONTENT, REGEX, or FUZZY
        SearchEngine->>MongoDB: database search
    end
    SearchEngine-->>Caller: search results

Loading

Flow diagram for conditional search index usage

flowchart TD
    A[SearchIndex.search] --> B{SEARCH_MEMORY_INDEX_EAGER_BUILD}
    B -- enabled --> C[_get_index_for_search]
    B -- disabled --> D{Search type}
    C --> D
    D -- TEXT --> E[_text_search]
    D -- FUNCTION --> F[_function_search]
    D -- CONTENT --> G[_content_search]
    D -- REGEX --> H[_regex_search]
    D -- FUZZY --> I[_fuzzy_search]
    E --> J{SEARCH_MEMORY_INDEX_ENABLED}
    F --> J
    J -- enabled --> K[SearchIndex.get_index]
    J -- disabled --> L[MongoDB $text fallback]

Loading

File-Level Changes

Change	Details	Files
Make in-memory search-index construction conditional and configurable.	Add enable/disable and eager-build settings with configuration inspection and documentation. Build the index only for search types that consume it, while preserving an opt-in warm-index path for completion suggestions. Fall back cleanly when the index is disabled and remove the fuzzy-search dependency on it.	config.py docs/configuration.rst docs/environment-variables.rst docs/workflows/search-flow.rst search_engine.py services/config_inspector_service.py
Prevent text searches from mutating index state and lock down search behavior with tests.	Copy indexed file sets before applying prefix matches so repeated searches remain correctly scored. Test build/no-build behavior across search types, configuration switches, eager warming, fallback defaults, and observable logging. Test that repeated text searches do not pollute the stored index or alter relevance scores.	tests/test_config.py tests/test_search_engine_index_built_only_when_used.py tests/test_search_engine_index_not_mutated_by_search.py
Improve search suggestion presentation, positioning, theming, and accessibility in the WebApp.	Move suggestions inside the input wrapper and use the native hidden state for visibility. Replace unavailable Bootstrap classes with project-specific styling, theme tokens, RTL-safe positioning, contained scrolling, and reduced-motion support. Add listbox/option semantics and adjust stacking and overflow behavior so the dropdown remains visible and usable.	webapp/static/css/global_search.css webapp/static/js/global_search.js webapp/templates/files.html

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[github-actions]

⏱️ Performance report

• Run: https://github.com/amirbiron/CodeBot/actions/runs/34163335326
• Artifact: perf-durations

(No performance test durations collected. Mark tests with @pytest.mark.performance.)

[github-actions]

📖 Documentation Preview

The documentation has been built successfully!

• 📦 Download Documentation Artifacts
• 🔍 Check the workflow summary for coverage report
• 📊 Build completed at: Mon, 07 Sep 2026 21:27:45 GMT

To view locally:

1. Download the artifacts
2. Extract the zip file
3. Open index.html in your browser

[sourcery-ai]

Sourcery assessment

Approved.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!