Implement github issue 1014

[amirbiron]

Docs: עדכון Connection Pooling ו-HTTP Sessions

מיישם את #1014 – יישור תיעוד ה‑ENV והקונפיגורציה לשדרוגי Pooling ולשימוש ב‑HTTP Sessions.

מה שונה

• ENV: הוספה/הרחבה של פרמטרי Pooling/Timeouts עבור MongoDB, Redis, aiohttp ו‑requests (כולל SAFE_MODE).
• HTTP Sync: תיעוד המודול http_sync.py ושימוש ב‑requests.Session גלובלי עם HTTPAdapter ו‑Retries.
• .env: דוגמאות קצרות ל‑Dev/Staging/Prod, כולל הערת Docker (שימוש ב‑service names ולא ב‑localhost).
• Performance: הנחיות כוונון (tuning) ופרק “בדיקות מהירות” לאחר שינוי ENV.

עמודים שעודכנו

• docs/environment-variables.rst
• docs/configuration.rst
• docs/performance-scaling.rst

דוגמת .env (תמציתי)

# Redis
CACHE_ENABLED=true
REDIS_URL=redis://redis:6379/0
REDIS_MAX_CONNECTIONS=100
REDIS_CONNECT_TIMEOUT=2.0
REDIS_SOCKET_TIMEOUT=3.0
SAFE_MODE=false
MongoDB
MONGODB_URL=mongodb://mongo:27017

DATABASE_NAME=code_keeper_bot

MONGODB_MAX_POOL_SIZE=100

MONGODB_MIN_POOL_SIZE=5

MONGODB_MAX_IDLE_TIME_MS=30000

MONGODB_WAIT_QUEUE_TIMEOUT_MS=5000

MONGODB_SERVER_SELECTION_TIMEOUT_MS=5000

MONGODB_SOCKET_TIMEOUT_MS=30000

MONGODB_CONNECT_TIMEOUT_MS=10000

MONGODB_RETRY_WRITES=true

MONGODB_RETRY_READS=true

MONGODB_APPNAME=CodeBot
aiohttp
AIOHTTP_POOL_LIMIT=100

AIOHTTP_LIMIT_PER_HOST=25

AIOHTTP_TIMEOUT_TOTAL=15
requests (http_sync)
REQUESTS_POOL_CONNECTIONS=20

REQUESTS_POOL_MAXSIZE=100

REQUESTS_TIMEOUT=8

REQUESTS_RETRIES=2

REQUESTS_RETRY_BACKOFF=0.2

מדוע

לספק תיעוד מעודכן, ברור ואחיד לשדרוגי Pooling/Timeouts ולשימוש ב‑Sessions (async/sync), כדי לשפר יציבות וביצועים ולהקל על כוונון לפי סביבה.

תוכנית בדיקות

1. התקנת תלויות דוקס:

   pip install -r docs/requirements.txt

2. בנייה מקומית עם אזהרות כשגיאות:

   sphinx-build -b html docs docs/_build/html -W --keep-going

3. מעבר ידני על העמודים המעודכנים לאימות קישורים, טבלאות וקטעי .env.

קריטריוני מעבר

• בנייה עוברת ללא אזהרות.
• עמודי התיעוד נטענים תקין והקישורים פנימיים עובדים.

סיכונים ו-Rollback

• סיכון נמוך (שינויי תיעוד בלבד). Rollback: החזרת קבצי RST לקודמתם.

קישורים

• CodeBot – Project Docs
• Issue: #1014

 

---

Note

Expands docs to cover MongoDB/Redis pooling and timeouts, HTTP client configuration (async/sync), new env vars, and performance-scaling guidance.

• Docs:
  • docs/configuration.rst:
    • Add sections for databases/cache pooling and timeouts (MONGODB_*, REDIS_*, SAFE_MODE).
    • Document HTTP clients: aiohttp (AIOHTTP_*) and sync http_sync with example and env-based pooling/retries.
    • Clarify Redis TLS note and Docker/Compose service hostnames.
  • docs/environment-variables.rst:
    • Expand reference table with MongoDB pooling/timeouts (MONGODB_MAX_POOL_SIZE, ..., MONGODB_APPNAME).
    • Add Redis and HTTP client knobs: REDIS_MAX_CONNECTIONS, REDIS_CONNECT_TIMEOUT, REDIS_SOCKET_TIMEOUT, SAFE_MODE, AIOHTTP_LIMIT_PER_HOST, REQUESTS_POOL_*, REQUESTS_TIMEOUT, REQUESTS_RETRIES, REQUESTS_RETRY_BACKOFF.
  • docs/performance-scaling.rst:
    • Add tuning guidance for MongoDB/Redis/aiohttp/requests pooling and timeouts.
    • Include post-change benchmarking/metrics checklist and environment-specific recommendations.

^{Written by Cursor Bugbot for commit bfac883. This will update automatically on new commits. Configure here.}

[cursor]

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
_{Learn more about Cursor Agents}

[github-actions]

🧯 Dangerous deletes guard report

Policy: see .cursorrules — dangerous deletions are blocked unless wrapped safely.

Summary:

• Flagged findings (blocking): 0
  0
• Excluded matches (not blocking): 15
• Total matches (all files): 125

Flagged findings (file:line:snippet):
(none)

Excluded matches (by path pattern)

./Dockerfile:34:    rm -rf /var/lib/apt/lists/*
./Dockerfile:76:    rm -rf /var/lib/apt/lists/*
./webapp/static/js/md_preview.bundle.js.map:4:  "sourcesContent": ["// Markdown-it plugin to render GitHub-style task lists; see\n//\n// https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments\n// https://github.com/blog/1825-t … [truncated]
./README.md:778:find . -name "__pycache__" -exec rm -rf {} +
./docs/DOCUMENTATION_GUIDE.md:453:rm -rf _build
./docs/Makefile:24:	rm -rf $(BUILDDIR)
./node_modules/mermaid/dist/chunks/mermaid.core/chunk-KS23V3DP.mjs.map:4:  "sourcesContent": ["{\n  \"name\": \"mermaid\",\n  \"version\": \"11.12.0\",\n  \"description\": \"Markdown-ish syntax for generating flowcharts, mindmaps, sequence  … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.esm.min/chunk-4HFYJGYH.mjs.map:4:  "sourcesContent": ["{\n  \"name\": \"mermaid\",\n  \"version\": \"11.12.0\",\n  \"description\": \"Markdown-ish syntax for generating flowcharts, mindmaps, sequen … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.esm.min/chunk-4HFYJGYH.mjs:1:var r={name:"mermaid",version:"11.12.0",description:"Markdown-ish syntax for generating flowcharts, mindmaps, sequence diagrams, class diagrams, gantt charts, git graph … [truncated]
./node_modules/mermaid/dist/chunks/mermaid.esm/chunk-2M32CCKP.mjs.map:4:  "sourcesContent": ["{\n  \"name\": \"mermaid\",\n  \"version\": \"11.12.0\",\n  \"description\": \"Markdown-ish syntax for generating flowcharts, mindmaps, sequence d … [truncated]
./node_modules/mermaid/dist/mermaid.min.js:1524:`,"getStyles"),c1e=RQe});var h1e={};dr(h1e,{diagram:()=>NQe});var NQe,f1e=N(()=>{"use strict";$ge();a1e();l1e();u1e();NQe={parser:Fge,db:n1e,renderer:o1e,styles:c1e}});var m1e,g1e=N(()=>{"use  … [truncated]
./node_modules/mermaid/dist/mermaid.js.map:4:  "sourcesContent": ["/**\n* Default values for dimensions\n*/\nconst defaultIconDimensions = Object.freeze({\n\tleft: 0,\n\ttop: 0,\n\twidth: 16,\n\theight: 16\n});\n/**\n* Default values for tr … [truncated]
./node_modules/mermaid/dist/mermaid.min.js.map:4:  "sourcesContent": ["/**\n* Default values for dimensions\n*/\nconst defaultIconDimensions = Object.freeze({\n\tleft: 0,\n\ttop: 0,\n\twidth: 16,\n\theight: 16\n});\n/**\n* Default values fo … [truncated]
./node_modules/katex/package.json:153:    "build": "rimraf dist/ && mkdirp dist && cp README.md dist && rollup -c --failAfterWarnings && webpack && node update-sri.js package dist/README.md",
./node_modules/katex/src/fonts/Makefile:139:	rm -rf pfa ff otf ttf woff woff2

[github-actions]

⏱️ Performance report

• Run: https://github.com/amirbiron/CodeBot/actions/runs/18731387749
• Artifact: perf-durations

(No performance test durations collected. Mark tests with @pytest.mark.performance.)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[github-actions]

📖 Documentation Preview

The documentation has been built successfully!

• 📦 Download Documentation Artifacts
• 🔍 Check the workflow summary for coverage report
• 📊 Build completed at: Wed, 22 Oct 2025 22:17:41 GMT

To view locally:

1. Download the artifacts
2. Extract the zip file
3. Open index.html in your browser