Repository navigation
fix: land #42 and #43 fixes on main (preview parse_failed, CORS :8080) - #74
Merged
Merged
Conversation
#42 and #43 were closed on 2026-10-10, but their fixes (15268ae, 09ff668) live only on PR #41's branch, which is unmerged and conflicts with main. This ports the code changes and regression tests onto main: - csvPreviewResultSchema accepts reason parse_failed plus message (#42) - default CORS_ORIGINS includes http://localhost:8080, the Vite dev port (#43) - docs, env.dev.example and start-frontend.ps1 updated to match - tests: preview-contract.test.ts (from 09ff668) and a CORS :8080 test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019YPoXzBSj89ZHgw7nfTmbB
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the fixes for #42 and #43 on
main. Found while resolving #48.Why
#42 and #43 were closed on 2026-10-10, but their fixes (commits 15268ae and 09ff668) exist only on
claude/elegant-bohr-zn28zn. That branch is the head of PR #41, which is unmerged and conflicts withmain. So both bugs are still present onmain:api/config.pydefaultCORS_ORIGINShas no:8080.csvPreviewResultSchemarejectsparse_failed.Change
These are the code changes from 15268ae, applied to
mainunchanged:csvPreviewResultSchemaaccepts reasonparse_failedwith an optionalmessage.CORS_ORIGINSaddshttp://localhost:8080.ENV_VARIABLES.md,README.md,env.dev.exampleandstart-frontend.ps1are updated to match.preview-contract.test.tsis taken from 09ff668 and placed in main's flat test layout.CorsHeaders.test_default_origins_include_vite_dev_portis new, and the existing unconfigured-origin test still guards against loosening the policy.Evidence
pytest -m "not integration and not e2e and not parity": 119 passed, 0 failed, 120 deselected. That is 118 before plus 1 new.npx vitest run: 7 files, 101 passed.parse_failedtest fails (1 failed, 5 passed). Both pass with the fix.PR #41's test regrouping still needs a rebase after this. Its copies of these commits will drop out as already applied.
Generated by Claude Code