Repository navigation
test: move #174 test into tests/unit (layout cleanup) - #234
Merged
Merged
Conversation
main's free-tier job fails at the merge of #204 (018edc2) on the "Test catalogue check" step: docs/TEST_CASES.md does not list test_docker_image_secrets.py. #204's own CI was green because it ran before main gained that gate, and #204's test file was written for the flat tests/ layout that #221 replaced. - Move tests/test_docker_image_secrets.py to tests/unit/ (it needs nothing: no database, no network), and point its ROOT one level deeper. - Regenerate docs/TEST_CASES.md with scripts/test_catalogue.py. Reproduced and cleared: `python3 scripts/test_catalogue.py --check` fails on main and passes here. Free tier in CI order: 257 passed, 0 failed, 0 skipped; lint, health, catalogue check and evals tier P clean. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011T6WqjTEDRRQGLEYPPFVXx
main (#224) regenerated docs/TEST_CASES.md after #204 merged, which cleared the red free-tier job this branch was opened to fix. What remains is the file move. The catalogue conflict is the only one; it is generated and gated by `test_catalogue.py --check`, so it is regenerated, not merged by hand. Free tier on the merged tree: 282 passed, 0 failed, 0 skipped; lint, health and the catalogue check clean. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011T6WqjTEDRRQGLEYPPFVXx
amar-python
changed the title
amar-python
marked this pull request as ready for review
November 10, 2026 07:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves #204's test into the folder
tests/README.mdprescribes. No longer a fix for a redmain.History, so the description matches reality
When opened, this fixed a red
main: the free-tier job failed at the merge of #204 (018edc2) becausedocs/TEST_CASES.mddid not listtests/test_docker_image_secrets.py(reproduced:python3 scripts/test_catalogue.py --checkfailed onmain). That is no longer true: #224 regenerated the catalogue after mergingmain, somainlists the file at its flat path and all four ofmain's CI jobs pass.What this still does
tests/test_docker_image_secrets.pytotests/unit/(it needs no database and no network;tests/README.mdputs that inunit/, and test: reorganise tests/ into category folders (#167) #221 retired the flat layout) and point itsROOTone level deeper (parents[2], as its siblings do).docs/TEST_CASES.mdso the entry moves with the file.Six tests, unchanged. Purely a layout change.
Verification (merged with current
main)Note
docs/TEST_CASES.mdis generated and CI gates on it, so any PR that adds or moves a test conflicts with it whenevermainregenerates it first. If this sits unmerged it will need regenerating again. Closing it is also reasonable: the benefit is only that one file lives in the right folder.https://claude.ai/code/session_011T6WqjTEDRRQGLEYPPFVXx
Generated by Claude Code