Repository navigation
fix(ui): accept the M5 log steps so versioned uploads don't show as Failed - #232
Merged
Merged
Conversation
…ailed The upload response is validated against a fixed list of log steps, and one unknown step makes zod reject the whole response. M5 (#109) added three steps in the loader (version, schema_check, cross_upload_duplicates) that the schema did not list, so a successful upload would have been reported in the UI as "Failed: Unexpected response shape". The log-step contract test added in #223 caught it, and has been failing the accessibility job on main since #229. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011T6WqhUfEMZv2Dxerqs2Eq
amar-python
marked this pull request as ready for review
November 10, 2026 06:31
amar-python
pushed a commit
that referenced
this pull request
Nov 10, 2026
…ma fix, #232) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011T6WqhUfEMZv2Dxerqs2Eq
amar-python
pushed a commit
that referenced
this pull request
Nov 10, 2026
#231 and #232 both added the three M5 log steps, so main lists version, schema_check and cross_upload_duplicates twice. zod collapses duplicate enum values, so it is harmless at runtime, but the duplicates were an accident. Remove them and add a test that reads the source (the parsed schema can't show them); it fails with a duplicate present. docs/ISSUE_TESTS.md: #174 is done on main (#204). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011T6Wqi8yaiaYWUVH8C4QAY
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the three log steps M5 introduced (
version,schema_check,cross_upload_duplicates) toprocessingLogSchemaincsv-table-hub-main/src/lib/csv.functions.ts.Why
The upload response is validated with zod, and an unknown log step rejects the whole response. Without this, a successful versioned upload is shown in the UI as "Failed: Unexpected response shape". This is the same failure class as #186 and #223.
The contract test from #223 (
log-step-contract.test.ts) catches it. It has been failing the accessibility job's vitest step onmainsince #229 merged, and on every PR based on it.Verification
log-step-contract.test.tsfails on currentmainwithexpected [ 'version', 'schema_check', ... ] to deeply equal [], the same error as CI.Not covered
No browser check of a real versioned upload in the UI. The contract test covers the schema, not the screen.
Generated by Claude Code