Repository navigation
fix(ui): Stop no longer pretends to cancel an import already on the server (#188) - #218
Merged
Merged
Conversation
…erver (#188) The UI created an AbortController but the request never used its signal: after Stop, the server still finished the import while the row said "Cancelled" and the result was discarded. Take option (a) from the issue: only offer Stop before the request is sent (reading/uploading), where it is true. Once it is sent, say so, and always show the server's result. True server-side cancellation stays with M6 staged imports (#110). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011T6Wqi8yaiaYWUVH8C4QAY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #188. Takes option (a) from the issue; option (b), true server-side cancellation, stays with M6 staged imports (#110), so I haven't closed the issue.
Problem
The UI created an
AbortControllerbut never gave its signal to the request. After Stop, the server still finished the import while the row said "Cancelled" and the result was discarded.Change
reading,uploading), where it is true: nothing has reached the server.canStop()injob-outcome.tsholds the rule, so the button and the tests share it.Tests
canStopunit test for every status.tscclean, no new lint errors beyond the existing formatting baseline.React stopgap: the Streamlit migration plan is #212.
Generated by Claude Code