Repository navigation
feat(frontend): show stored failure reasons in the Migrated files Preview (M3c, #107) - #139
Merged
Merged
Conversation
…view (M3c, #107) When a migrated file has failed rows, its Preview now loads the reasons from GET /api/csv/uploads/{id} and lists them, with an error report download. They come from the server, so any user in the tenant sees them, not only the browser that uploaded the file. vitest 143 passed (2 new); tsc 0; production build OK. End to end in Chromium with a fresh browser: the stored reason is shown, 0 page errors. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019YPoXzBSj89ZHgw7nfTmbB
amar-python
changed the base branch from
feat/107-m3b-source-preserved
to
main
October 28, 2026 01:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #107. Part M3c of ART Milestone 3, frontend side. This is stacked on #138, which stores the reasons on the server. Merge #138 first; this PR's base then moves to
main.What it does
GET /api/csv/uploads/{id}. It lists the row, column, value and reason, with an Error report download (CSV).Verification
stored-row-errors.test.tsx)tsc --noEmitcsv.functions.tsnode-server)"x" is not a whole numberfor row 2, columnn, plus the Error report button. There were 0 page errorsI broke the component to check that the test catches it: with the reason column rendering the column name instead, the test failed (1 failed, 1 passed).
Not in this PR: needs the product owner's call
The #107 scope note also says "include them in audit reports". The audit report today is the Import history page. That page is built entirely from the uploading browser's local storage, so another user's uploads aren't there to report on. There are two ways to close this:
GET /api/csv/uploadsnow, as an extra M3 part.My recommendation is (b): M7 replaces that page's data source, so doing it in M3 would be done twice.
Generated by Claude Code