Skip to content

Live pointers to superseded docs/API_INTEGRATION.md need to be resolved #164

Closed as not planned

Description

@amar-python

Context

docs/API_INTEGRATION.md describes a July 2026 design where the API shelled out to csv_loader.sh. The current design (routers and services in api/, running FastAPI directly) replaced that long ago, and the file carries its own superseded note at the top.

The Project knowledge instructions already flag API_INTEGRATION.md as describing a superseded API. The problem is that the file is still referenced from live docs that new readers hit:

  • README.md and docs/QUICKSTART.md both link to docs/API_INTEGRATION.md as "frontend ↔ backend endpoint mapping"
  • docs/STARTER_GUIDE.md (PR docs: starter guide #63) adds a similar reference in its "Where to go next" pointer list

A new reader following any of these pointers lands on content that describes a design that has not shipped since July. The superseded banner at the top of API_INTEGRATION.md helps, but readers may not scroll back to the top after following a link into a specific section.

Options

Two ways to resolve, both honest. Product owner's call:

(a) Strengthen the superseded banner on docs/API_INTEGRATION.md itself. Add a prominent "DO NOT USE AS CURRENT REFERENCE" header, visible from any anchor link, with pointer to the current source of truth (api/routers/*.py). File stays in the repo for history; live references continue to work but readers are warned loudly.

(b) Remove references to docs/API_INTEGRATION.md from all live docs (README.md, docs/QUICKSTART.md, and docs/STARTER_GUIDE.md once PR #63 merges). File stays in the repo but new readers never find it through navigation. Current API documentation lives entirely in code comments + the OpenAPI schema at /api/docs.

(c) Both — strengthen the banner AND remove live pointers. Belt-and-braces.

Done when

  • Decision taken (a/b/c) and recorded in a comment on this issue
  • Edits applied in one PR, with the resulting state verified: a reader starting from the README cannot land on API_INTEGRATION.md without an explicit "this is historical" signal

Related

Activity

  1. amar-python commented on Nov 8, 2026

    @amar-python
    OwnerAuthor

    Closing: the premise does not hold at 74c248f

    Checked docs/API_INTEGRATION.md on main today. Two of the issue's load-bearing claims are no longer true:

    1. There is no superseded note on the file. The issue says "the file carries its own superseded note at the top". It does not — grep -i -E "supersed|historical|out of date|do not use" docs/API_INTEGRATION.md returns nothing. So option (a) "strengthen the banner" would mean adding one, not strengthening.

    2. The file does not describe the July shell-out design. No mention of csv_loader.sh anywhere in it. Its architecture diagram is csv-table-hub-main/ (React 19) → api/ (FastAPI) → PostgreSQL, and its endpoint table lists routes that exist at HEAD:

    Documented Live?
    GET /api/health yes — api/main.py:111
    POST /api/csv/preview yes
    POST /api/csv/upload yes
    GET /api/csv/files yes
    GET /api/csv/tables/{table}/rows yes
    DELETE /api/csv/files/{id} yes
    POST /api/auth/login, POST /api/auth/oidc (prose, §Auth) yes — Milestone 2

    It was last touched 4 Nov 2026 (Merge pull request #197), i.e. after this issue was filed on 3 Nov. Whatever the July state was, the file has moved on.

    So the "Done when" — "a reader starting from the README cannot land on API_INTEGRATION.md without an explicit 'this is historical' signal" — is the wrong goal: the content is not historical, and labelling it so would make the docs less accurate, not more. Closing as not applicable rather than as done.

    What was actually wrong, and what was fixed

    Two real defects came out of the check, both fixed in #206:

    • docs/STARTER_GUIDE.md promised the file shows "every frontend↔backend API call". It documents 8 of the 22 live routes. Softened, with a pointer to the OpenAPI schema.
    • docs/prompts/ART_FRAMEWORK.md:240 told every agent reading the framework that "API_INTEGRATION.md describes a superseded API" — stale, and the likely origin of this issue's premise. Removed.

    The remaining genuine gap — 14 live routes the file never mentions — is tracked in #207 so it is scoped as "incomplete reference" rather than "superseded design".

    The six live pointers (README.md:146, docs/QUICKSTART.md:7,299,310, docs/STARTER_GUIDE.md:53,115) are left in place. They point at a partial but current doc, which is what they now say they do.


    Verified by Claude Code against main at 74c248f


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions