Fix: Inform user if there's no internet connection while trying to ac… - #448
Fix: Inform user if there's no internet connection while trying to ac…#448balaji-ramavathu wants to merge 0 commit into
Conversation
f9ff6b9 to
6d5a497
Compare
|
Great idea. It is good to have such indicator messages on the app. Maybe we can do better with the messages and the checks though. There is a possibility the user is running a local server which means he won't need to be connected to the internet to access his files. (Basically accessing files on a local server via a Wifi network.) This messages might come up at the wrong time in this case. However there is still a good chance, the Wifi network gets disconnected and the files on the local server cant be access. We will need to have appropriate checks and messages for these situations. |
|
hey @codedentwickler how do I check if the user is running a local server? |
|
Yes, An easy way is to do a check like in the snippet below. You can understand how auto, remote and local connections is used by observing how this shared preference key
|
|
@codedentwickler thanks! I will add these checks :-) |
6d5a497 to
f0e8a88
Compare
|
@codedentwickler I've added checks and messages for the local server case. |
|
This is a really good feature and works fine on testing on both local as well as on remote connections, I recommend @cpg to Merge this PR. |
|
Something wrong happened. Some issues while merging instead closed the PR. |
…cess media files
Fixes #447
Summary
Please Add Screenshots If any UI changes.
For audio (same for all other types) :
If internet goes off while playing video :