Skip to content

Show existing event covers and photos in event heroes - #28

Merged
esthor merged 1 commit into
mainfrom
esthor/event-hero-media
Sep 21, 2026
Merged

esthor merged 1 commit into
mainfrom
esthor/event-hero-media

Conversation

@esthor

@esthor esthor commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Event heroes now display the stored event cover, then an available event photo, with the existing illustration as a fallback. Poster artwork retains its aspect ratio and image metadata.

Validation: three tests cover image precedence and fallbacks; TypeScript and formatting checks.

@vercel

vercel Bot commented Sep 21, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
allthingsweb Ready Ready Preview Sep 21, 2026 8:09pm UTC

Request Review

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: allthingsweb-dev/allthingsweb/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: e3cdb114-309f-4f24-811b-b1ea2f2cdb27

📥 Commits

Reviewing files that changed from the base of the PR and between 51cfd70 and df7cc4c.

📒 Files selected for processing (3)
  • app/src/components/event-details.tsx
  • app/src/lib/event-hero.ts
  • app/tests/event-hero.test.ts

Comment @coderabbitai help to get the list of available commands.

@esthor

esthor commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

CodeRabbit CLI reviewed commit df7cc4cd58b34bc7c1052a83e4d3ffbb12d42f21 against 51cfd702a38d575b916bbbb7d06ebbdf985ff605 and completed with 0 issues across all three changed files. The GitHub bot was rate-limited; its green status is not the review evidence.

Validation at the same head: local TypeScript, formatting and 22 tests passed; GitHub CI and Vercel preview build passed. No unresolved review threads. Preview browsing is protected by the owning Vercel team; production smoke verification follows deployment.

@esthor
esthor merged commit bb58eeb into main Sep 21, 2026
4 checks passed
@esthor

esthor commented Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Production verified at merge bb58eebe726b1f1bb0cda5c516c4e81cd6e3b6e9: Vercel Production deployment 6577208899 and post-merge CI succeeded. The Convex event hero now renders its actual event photo (loaded successfully in browser); 390px layout has no horizontal overflow. Home, About, Speakers, a generic photo event, the upcoming Effect event, and the custom Mux event all return 200 without a server error. All 35 published events retain their prior IDs and historical fields; RSS still has 35 entries. Vercel runtime logs could not be inspected because the connected account lacks access to the owning team.

This branch was successfully deployed

1 active deployment
Preview df7cc4cd Deployed Sep 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant