Fix past speakers to follow public event appearances - #27
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Understand this PR’s impact Explore downstream dependencies and potential security impact with Blast Radius. Warning Review limit reachedNext included review available in 56 minutes. View limit detailsLimit details: You’ve used the included review currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: Repository: allthingsweb-dev/allthingsweb/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: allthingsweb-dev/allthingsweb/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🧰 Additional context used📓 Path-based instructions (6)Use bun test and write tests using bun:test (import { test, expect } from "bun:test")📄 CodeRabbit inference engine (.cursor/rules/use-bun-instead-of-node-vite-npm-pnpm.mdc) Files:
Do not use Bun-specific APIs in production code; ensure compatibility with Node.js runtime📄 CodeRabbit inference engine (.cursor/rules/use-bun-instead-of-node-vite-npm-pnpm.mdc) Files:
Use pre-built Stack UI components (e.g., , , ) when building auth UI In Client Components, retrieve the current user via useUser(); use useUser({ or: "redirect" }) for protected pages In Server Components, use...📄 CodeRabbit inference engine (.cursor/rules/neon-auth.mdc) Files:
Define TanStack DB collections using createCollection with the appropriate options creator (e.g., queryCollectionOptions, electricCollectionOptions, localOnlyCollectionOptions, liveQueryCollectionOptions) rather than ad-hoc stores Always pr...📄 CodeRabbit inference engine (.cursor/rules/electric-sql-tanstack-db.mdc) Files:
In mutationFn implementations, ensure server writes have synced back before returning (e.g., await collection.refetch() or equivalent) so optimistic state can be safely discarded When creating a collection, prefer supplying a Standard Schem...📄 CodeRabbit inference engine (.cursor/rules/tanstack-db.mdc) Files:
In React components, use the useLiveQuery hook to bind live query results to component state📄 CodeRabbit inference engine (.cursor/rules/tanstack-db.mdc) Files:
🪛 OpenGrep (1.29.0)app/tests/speaker-directory.test.ts[ERROR] 17-17: Dynamic command passed to child_process.exec/execSync. Use child_process.execFile or spawn with an argument array instead. (coderabbit.command-injection.exec-js) 🔇 Additional comments (4)
📝 WalkthroughWalkthroughThe change adds a shared speaker directory query, updates speaker data loading to use it, adds database-backed tests, and changes speaker-page filtering to use ChangesSpeaker directory flow
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant SpeakersPage
participant getSpeakersWithTalks
participant getSpeakerDirectory
participant Database
SpeakersPage->>getSpeakersWithTalks: load speakers and talks
getSpeakersWithTalks->>getSpeakerDirectory: query directory
getSpeakerDirectory->>Database: select published past-event data
Database-->>getSpeakerDirectory: joined rows
getSpeakerDirectory-->>getSpeakersWithTalks: grouped speakers and talks
getSpeakersWithTalks-->>SpeakersPage: mapped speaker data
SpeakersPage->>SpeakersPage: filter talks by speakerIds
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
✨ Simplify code
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
CodeRabbit CLI completed a fresh review of final head Local TypeScript, formatting and 23 tests passed. GitHub CI and Vercel preview build passed at the same head; there are no unresolved review threads. Production verification follows the guarded merge. |
|
Production verified for merge |
This branch was successfully deployed
1 participant
The past-speaker directory now derives speakers and talk links from the same published, completed events. This includes organizers who gave talks, excludes draft or unlinked talks, and preserves repeat appearances and co-speakers.
Validation: three PGlite integration tests cover publication and time boundaries, organizer participation, co-speakers, repeated talks, and an empty directory; TypeScript and formatting checks. No database migration.
Summary by CodeRabbit
New Features
Bug Fixes