Use Luma as the source of truth for event registration - #26
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details🧰 Additional context used📓 Path-based instructions (5)Do not use Bun-specific APIs in production code; ensure compatibility with Node.js runtime📄 CodeRabbit inference engine (.cursor/rules/use-bun-instead-of-node-vite-npm-pnpm.mdc) Files:
Use pre-built Stack UI components (e.g., , , ) when building auth UI In Client Components, retrieve the current user via useUser(); use useUser({ or: "redirect" }) for protected pages In Server Components, use...📄 CodeRabbit inference engine (.cursor/rules/neon-auth.mdc) Files:
Define TanStack DB collections using createCollection with the appropriate options creator (e.g., queryCollectionOptions, electricCollectionOptions, localOnlyCollectionOptions, liveQueryCollectionOptions) rather than ad-hoc stores Always pr...📄 CodeRabbit inference engine (.cursor/rules/electric-sql-tanstack-db.mdc) Files:
In mutationFn implementations, ensure server writes have synced back before returning (e.g., await collection.refetch() or equivalent) so optimistic state can be safely discarded When creating a collection, prefer supplying a Standard Schem...📄 CodeRabbit inference engine (.cursor/rules/tanstack-db.mdc) Files:
In React components, use the useLiveQuery hook to bind live query results to component state📄 CodeRabbit inference engine (.cursor/rules/tanstack-db.mdc) Files:
🔇 Additional comments (7)
📝 WalkthroughWalkthroughThe event pages no longer retrieve Luma attendee counts or calculate capacity. Shared event components no longer render capacity-based states and now link directly to Luma event details. ChangesEvent capacity removal
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~15 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to Events with Luma pages retain valid registration or details links, while site-only events do not receive an invalid destination. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
✨ Simplify code
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public event pages combine a live guest count with an old stored capacity. After draft recovery, All Things Sync showed “500 / 200 guests registered”; future events can also falsely appear closed. Rendering also depends on a separate Luma attendee request.
Delegate registration and availability to the event’s Luma page. Remove guest-count fetches, capacity banners and derived waitlist decisions from the generic event page and the five custom historical event pages. Keep registration links, past-event notices and all stored historical data. Events without a Luma link show their event details without inventing a registration destination.
Validation: TypeScript, formatting, diff checks and all 19 existing tests (87 assertions) pass. Confirmed no public event page still calls the attendee counter. After deployment, verify All Things Sync, Effect San Francisco, a custom historical event and a site-only historical event; confirm stored capacities and the 35-event archive remain unchanged.
Merged as
51cfd702a38d575b916bbbb7d06ebbdf985ff605after CodeRabbit approved the exact head with no issues and all checks passed. Main CI and production deployment succeeded. Production verification passed on all eight selected event pages, including the generic and five custom routes: no stale capacity claims remain, and upcoming events link to Luma availability. The 35-event archive and stored capacities are unchanged. RSS and sitemap still parse and contain all public event URLs.