[RCL-45] rcl-converge skill: route exit 0 through step 2a, harden the detached wrapper, carry the run id in pending entries - #56
Merged
Conversation
… detached wrapper, carry the run id in pending entries - Every rcl exit=0 goes to step 2a, so rule 1 writes the evidence: none ledger line when the loop is not evidenced. - The detached wrapper installs its signal handler before backgrounding rcl; the handler reaps rcl and exits 143, so a killed review never logs rcl exit=0 (dash sets $? to the handler status after a trapped wait). - Pending ledger entries record run=<run id>, so a resume after /tmp cleanup can flush the run without the JSON report.
…n; recorded replaces the whole pending state
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skill text only (
skills/src/rcl-converge.md, three variants regenerated withnpm run build:skills); rcl itself is unchanged.rcl exit=0now goes to step 2a in both variants, so its rule 1 writes theevidence: none (<reason>)ledger line for an unevidenced loop instead of the round continuing without a ledger evidence state.on_signal, a function so$rcl_pidis read at signal time) is installed before rcl is backgrounded; it forwards TERM, reaps rcl and exits 143 — indash,$?after a signal interruptswaitis the handler's status, so the old wrapper loggedrcl exit=0for a killed review. The prose states that the PID file names rcl, not the wrapper, and that thercl exit=line is appended after rcl is gone.evidence: pending run=<run id>andevidence: pending (flush timed out) run=<run id>, so a resume after/tmpcleanup canrcl telemetry flush --run <run id>without the JSON report; the ledger format section says so.test/skills/generated.test.tspins the new wrapper shape and the pending line. Vendored copies in allocator-one follow in a separate PR (the fork port takes items 1 and 3; it has no detached wrapper).npm run lint && npm testgreen.RCL-45