fix(web): per-trigger suggestion labels and font-preview ARIA gating - #1
Merged
akj merged 2 commits intoSep 18, 2026
Conversation
A single "Composer suggestions" name tells a screen reader user that a list
opened but not which one. Naming it by trigger ("Files and folders",
"Commands", "Skills", "Pull requests") says what the options are before
any row is read.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
ComposerPromptEditor is also the Settings font preview, which has no trigger menus. Hardcoding the "Message" label, aria-autocomplete and aria-haspopup on the editor made that preview announce as a chat field with autocomplete. The chat composer now opts in by passing the label and its listbox id; the font preview passes neither and reads as a plain multiline field. aria-controls follows the active option rather than list visibility, which is the same moment in practice but keeps the reference from ever pointing at a listbox with no highlighted row. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
4 tasks done
github-actions
Bot
added
vouch:unvouched
akj
merged commit Sep 18, 2026
2c5b68b
into
akj:fix/composer-screen-reader-suggestions
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries the two pieces from pingdotgg#11666 you called out into pingdotgg#10154, so the composer accessibility work lands in one place. Two commits, take or drop either independently.
Per-trigger listbox labels.
Composer suggestionsbecomesFiles and folders/Commands/Skills/Pull requests, so the list says what it holds before the first row is read.Suggestion ARIA stays off editors without menus.
ComposerPromptEditoris also the Settings font preview, which has no trigger menus. WithariaLabel="Message",ariaAutoComplete="list"andaria-haspopup="listbox"hardcoded, that preview announced as a chat field with autocomplete. The chat composer now opts in by passingariaLabeland always passingsuggestionListId(capability);activeSuggestionIdstays gated on list visibility and drivesaria-activedescendantandaria-controls. The font preview passes neither and reads as a plain multiline field.aria-multilinestays static since it is true of both.One thing I left alone but want to flag:
encodeURIComponentincomposerSuggestionOptionIdthrowsURIErroron a lone surrogate, which NTFS permits in file names. pingdotgg#11666 used a fixed-width%XXXXescape of[\s%]instead. Rare enough that I did not want to widen this PR; happy to add it if you want it.Verified:
tsc --noEmitclean forapps/web, targeted lint shows only the pre-existingset-state-in-effectwarnings inChatComposer.tsx, andComposerCommandMenu.test.tsx+composerMenuHighlight.test.tspass (8 tests).🤖 Generated with Claude Code