Repository navigation
docs: list every shape and control helper in place of add_shape/add_control - #444
Merged
Merged
Conversation
…ontrol The README's known limits and the API reference named only the line, rectangle and ellipse helpers as the way past the low-level add_shape() and add_control(). List the arc, polygon, curve, connector and container helpers too, and the column definition, bookmark and hyperlink controls. Refs #51 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
리뷰 결과: 머지 전에 하나만.
확인한 것: 나열한 메서드는 모두 문단( |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
다시 리뷰: 병합합니다. ef8f9de4로 README_EN.md의 Known limitations도 같은 목록(도형 8, 컨트롤 3)이 되었고, 예제 원장의 두 README 해시가 커밋된 내용(LF)과 같습니다. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
바뀐 점
README의 "알려진 제약"과 API 참조가 도형 전용 메서드 중 선·사각형·타원만 안내하던 것을, 지금 있는 메서드 전부로 고친다.
README.md:add_shape()/add_control()대신 쓸 메서드로add_line()/add_rectangle()/add_ellipse()/add_arc()/add_polygon()/add_curve()/add_connector()/add_container()(묶음)와 컨트롤용add_column_definition()/add_bookmark()/add_hyperlink()를 적는다.README_EN.md: Known limitations에 같은 목록을 영어로 적는다.docs/api_reference.md:HwpxOxmlParagraph의 도형 메서드 목록에 호·다각형·곡선·연결선·묶음을 더한다.docs/python-example-ledger.json:README.md·README_EN.md의 고정 해시(manualSha256)를 새 내용으로 바꾼다. 두 README의 코드 블록은 그대로다.Refs #51 — 이 이슈의 목표(한/글이 여는 완전한 개체 XML)는 위 전용 메서드들이 채운다.
add_shape()/add_control()(6.0부터doc.shapes.add_raw/doc.shapes.add_control)은 일부러 남긴 저수준 탈출구로, 하위 요소가 빠지면 경고한다(tests/test_shape_geometry_contract.py).테스트
tests/test_documentation_code_fences.py의 원장 검사가 새 해시로 통과한다.tests/test_contract_docs_sync.py,tests/test_stable_surface.py통과.🤖 Generated with Claude Code