consistent-return and promises

[olalonde]

I kind of like the consistent-return rule except when using promises. I often find myself writing this style of code:

const something = () => {
    return somePromise().then((someval) => {
      if (!someval) return;
      return someOtherPromise();
   });
};

What should I put as return value in the first return? return null fixes the

[ljharb]

return null or return undefined or return Promise.resolve() or if (someval) { return someOtherPromise(); } are all some options

[justjake]

I don't like consistent return and usually turn it off on a file by file basis, or across a project.

[graingert]

@ljharb if (someval) { return someOtherPromise(); } doesn't work, because there's an implicit return undefined, which is what this rule is trying to prevent.

[ljharb]

Ah, true. in that case, return someval ? someOtherPromise() : Promise.resolve(); is probably ideal.