Skip to content

Folia Support - #25

Closed
ItsRainingHP wants to merge 2 commits into
aikar:masterfrom
ItsRainingHP:master
Closed

ItsRainingHP wants to merge 2 commits into
aikar:masterfrom
ItsRainingHP:master

Conversation

@ItsRainingHP

Copy link
Copy Markdown

Added Folia module which utilizes GlobalRegionScheduler.

@ItsRainingHP ItsRainingHP mentioned this pull request Jan 10, 2024
@chickeneer

Copy link
Copy Markdown
Collaborator

I think I am probably on this repo and what-not. I'll take a look at it later today or tomorrow.

In general. I will say that this PR would indeed add some bare minimum folia compatibility. But it is incomplete in the grand picture of the goals of Folia. Specifically, that someone's goal shouldn't be to use the global scheduler sync for many things, but we need to design a new api which syncs to some region's scheduler. If that makes sense. Whereas 'traditional' mc just has sync or async - main thread or async. Folia would have all of its different "regions" that needs to be an option for taskchain to attach to.

@ItsRainingHP

Copy link
Copy Markdown
Author

I agree. This was just bare minimum support to make it work. I intended to add region specific scheduling but wanted to put it out there for review.

@chickeneer

Copy link
Copy Markdown
Collaborator

Yeah, if you PR it, I can get it merged. I don't see myself committing to much more than that for folia :/

@ItsRainingHP

Copy link
Copy Markdown
Author

I understand. Its not officially released yet, but I do want to add Folia support to my plugin eventually.

@ItsRainingHP ItsRainingHP closed this by deleting the head repository May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants