Skip to content

Add RAC submenu to homepage and tailwind starter - #5919

Merged
reidbarber merged 3 commits into
mainfrom
rac-submenu-homepage
Feb 27, 2024
Merged

reidbarber merged 3 commits into
mainfrom
rac-submenu-homepage

Conversation

@reidbarber

Copy link
Copy Markdown
Member

This was removed from #5648 before the last release.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Test docs homepage and tailwind starter storybook.

🧢 Your Project:

@rspbot

rspbot commented Feb 21, 2024

Copy link
Copy Markdown

<MenuItem id="favorite"><StarIcon aria-hidden className="w-4 h-4" /> {item.isFavorite ? 'Unfavorite' : 'Favorite'}</MenuItem>
<MenuItem id="edit"><PencilIcon aria-hidden className="w-4 h-4" /> Edit…</MenuItem>
<MenuItem id="delete"><TrashIcon aria-hidden className="w-4 h-4" /> Delete…</MenuItem>
<SubmenuTrigger>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a followup task to add a header and section to this example some time?

@rspbot

rspbot commented Feb 26, 2024

Copy link
Copy Markdown

@rspbot

rspbot commented Feb 26, 2024

Copy link
Copy Markdown
## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@reidbarber
reidbarber merged commit 4161265 into main Feb 27, 2024
@reidbarber
reidbarber deleted the rac-submenu-homepage branch February 27, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants