Skip to content

Ensure 2 renders for submenu portal container - #5828

Merged
reidbarber merged 3 commits into
mainfrom
ensure-second-render-portalcontainer
Feb 8, 2024
Merged

reidbarber merged 3 commits into
mainfrom
ensure-second-render-portalcontainer

Conversation

@snowystinger

@snowystinger snowystinger commented Feb 7, 2024 •

Copy link
Copy Markdown
Member

Found in audit

Closes

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@rspbot

rspbot commented Feb 7, 2024

Copy link
Copy Markdown

@reidbarber

Copy link
Copy Markdown
Member

Feel free to throw the change from #5803 in here, or we can just do that after this is merged.

@rspbot

rspbot commented Feb 8, 2024

Copy link
Copy Markdown

@rspbot

rspbot commented Feb 8, 2024

Copy link
Copy Markdown
## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

@reidbarber
reidbarber merged commit 77fa19d into main Feb 8, 2024
@reidbarber
reidbarber deleted the ensure-second-render-portalcontainer branch February 8, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants