Repository navigation
Provide access to portalContainer of react-aria-components popover element - #5381
Conversation
reidbarber
left a comment
There was a problem hiding this comment.
Thanks for the PR!
If you sign the CLA, then close and re-open this PR, it should re-build and pass CI.
|
Thanks @reidbarber, all done 👍 |
|
@devongovett @dannify any chance this can be included in the November release? It's a small change that exposes RAC functionality already provided by existing code. |
|
Hey, we're already done with testing for this release, so it won't be in this one. The team has some concerns about assumptions we've made with regards to the portalContainer, so we'll be wanting to spend a little time focused on discussions about this. Hopefully we'll have a chance to look at it after we complete the current release. |
|
Thanks @snowystinger 👍 |
LFDanLu
left a comment
There was a problem hiding this comment.
LGTM, tested locally and verified that the portalcontainer is being set properly. Will approve when the conflict is updated
#5382
Also:
✅ Pull Request Checklist:
🧢 Your Project:
PageUp/GEL