Skip to content

Update of CM pipeline settings doesn't validate branch/tag existence #492

Description

@jwadolowski

Expected Behavior

User input (branch/tag/repositoryId) must be validated upon update of CM pipeline settings.

Actual Behavior

aio cloudmanager:pipeline:update ends successfully for not existing branches/tags.

Reproduction Scenario, Platform, and Version

$ aio -v
@adobe/aio-cli/8.1.0 darwin-x64 node-v14.17.6

Steps to Reproduce

$ aio cloudmanager:pipeline:update PIPELINEID -p PROGRAMID --branch=this-branch-does-not-exist
updating pipeline... updated pipeline ID <PIPELINEID>

$ aio cloudmanager:pipeline:update PIPELINEID -p PROGRAMID --tag=not-existing-tag
updating pipeline... updated pipeline ID <PIPELINEID>

Once above is set you can start the pipeline, but it's gonna fail immediately at validation stage with the following message:

Failed: Invalid pipeline: . Reason=Branch=this-branch-does-not-exist not found in repository (Finished: September 22, 2021 11:14:23 AM GMT+2)

In contrast repository ID is being validated, so I assume that it may require some backend API changes:

$ aio cloudmanager:pipeline:update PIPELINEID -p PROGRAMID --repositoryId=123456
updating pipeline... failed
 ›   Error: [CloudManagerSDK:ERROR_UPDATE_PIPELINE] Cannot update pipeline: https://cloudmanager.adobe.io/api/program/PROGRAMID/pipeline/PIPELINEID (400 Bad Request) - Validation
 ›   Error(s): Referenced repository not found in application or is not ready for use: 123456
 ›   Code: ERROR_UPDATE_PIPELINE

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions