Repository navigation
Upgrade Ruff to 0.16.0 and make Workers CI reliable - #2
Merged
Merged
Conversation
adewale
changed the title
adewale
marked this pull request as ready for review
October 9, 2026 10:40
adewale
pushed a commit
that referenced
this pull request
Oct 10, 2026
…udit-fixes Conflicts resolved by asking whether main already does what this PR did: - Ruff pin (pyproject.toml, uv.lock, .pre-commit-config.yaml): main's 0.16.0 supersedes this PR's 0.15.2. Took main's. - ci.yml: main already runs `uv run ruff check .` in its test job. The PR's separate `lint` job is dropped; its remaining hooks (ruff format, codespell, file hygiene) run as one step in main's test job with SKIP=ruff, so each check runs exactly once. Main's uv 0.12.3 pin and UV_PYTHON stay; the PR's warm-every-directory install loop stays. - 2-fastapi-r2-streaming: main fixed the FastAPI >=0.142 startup failure by importing the app inside the request handler (src/app.py), so the PR's fastapi<0.142 pin there is dropped. The PR's word-pattern /seed data moves into src/app.py. - 4-r2-large-binary-roundtrip: main did not change its module-level FastAPI import, so the fastapi<0.142 pin is kept on top of main's dependency list (webtypy removed, workers-py pinned). - 5-sync-http-libraries and test_5: main's ECHO_URL Worker variable and header_echo_server fixture supersede the PR's request-controlled ?echo= override, its loopback validation, tests/echo_server.py and the live httpbin.org call (main removed httpbin from CI on purpose). Took main's entry.py, README and test_5; deleted tests/echo_server.py. - test_3: main's echo-server assertions plus the PR's strict xfail marker and PlatformBugReproduced. - tests/conftest.py: main's ECHO_URL wiring and process-group teardown; the PR's output-drain thread and early-exit error for startup. - LESSONS_LEARNED.md: main's entries 7 and 8 kept; the PR's entries are renumbered 9 and 10. - Lockfiles regenerated with `uv lock` (uv 0.12.3), not hand-merged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012eisRQmQvg4TphwztxhQGJ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Adopt Ruff 0.16.0 and fix the integration suite's underlying failures. These also occur without the Ruff changes: unavailable external echo services and Workers/dependency drift broke the existing tests.
Changes
ECHO_URLoverride for the HTTP header demonstrations.webtypyfrom runtime dependencies, pinworkers-pyto 1.17.7 and CI's uv to 0.12.3, and explicitly use Python 3.13.Validation
uv run pytest -vv -s— 2 passed, 3 skipped, 1 xfailed.uv run ruff check .and staged diff whitespace checks pass.Risk
Moderate: the Worker development toolchain changes. The loopback integration server removes an external uptime dependency without suppressing the intended platform bug reproduction. GitHub's clean Linux CI run is the final merge gate.