Repository navigation
Update: Use npm for install, update and uninstall where required (fixes #175) - #189
Closed
oliverfoster wants to merge 11 commits into
Closed
oliverfoster wants to merge 11 commits into
oliverfoster wants to merge 11 commits into
Conversation
added 2 commits
March 4, 2023 08:56
| @@ -158,26 +158,83 @@ export default class Target extends Plugin { | |||
|
|
|||
| async install ({ clone = false } = {}) { | |||
There was a problem hiding this comment.
the install function is quite lengthy, can any of this be separated out into individual functions?
eleanor-heath
approved these changes
Mar 10, 2023
github-project-automation
Bot
moved this from Assigned
to Recently Released
in adapt_framework: The TODO Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #175
refs adaptlearning/adapt_framework#3370
New
Notes