fix(web): restore padding in provider sign-in setup box - #5
Merged
Merged
Conversation
Upstream pingdotgg#10571 aligned provider settings with shared settings rows: ProviderSetupSection was converted to SettingsRows, which carry their own padding, so the <div className="px-3 py-3 sm:px-4"> wrapper around the card's setup slot was removed. ProviderAuthSection still rendered free-form content relying on that wrapper, so after the merge the sign-in section sat flush against the Setup box edges. Convert ProviderAuthSection to the same SettingsRow structure: a sign-in row carrying the status line and the flow/sign-out controls, a sign-in method row holding the picker or the pasted-credential form, and a readout row for the recorded method, matching ProviderSetupSection's layout in the same card. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ProviderSetupSectionwas converted toSettingsRows (which carry their ownpx-3 sm:px-4 py-3padding), and the<div className="px-3 py-3 sm:px-4">wrapper aroundProviderInstanceCard'ssetupslot was removed.ProviderAuthSectionstill rendered free-form content that relied on that wrapper, so after the merge its content sat flush against the Setup box edges (see before shot).ProviderAuthSectionto the sameSettingsRowstructure asProviderSetupSection: a sign-in row carrying the status line plus flow/sign-out controls, a sign-in method row holding the picker or pasted-credential form, and a readout row for the recorded method. The section now owns its own padding and matches the Antigravity setup rows in the same card.Before / after
Signed in:
Signed out / disabled:
Test plan
vp run dev+ seeded state): signed-in state shows padded rows with right-aligned Sign out; disabled state shows the enable block, status, and method picker rowsvp run --filter web typecheck,vp lint,vp fmt --checkon the touched fileGenerated with Devin