Repository navigation
Remove spyon, use readable stream to test pipeResponseToFile - #651
Merged
Merged
Conversation
hashtagchris
force-pushed
the
hashtagchris-test-pipeResponseToFile
branch
from
November 26, 2020 03:51
0c4524a to
6ccf139
Compare
2 of 3 tasks
yacaovsnc
approved these changes
Nov 30, 2020
yacaovsnc
left a comment
yacaovsnc
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks for adding the check for file length.
at-wat
pushed a commit
to at-wat/actions-toolkit
that referenced
this pull request
Aug 31, 2023
…#651) * Remove spyon, use readable stream to test pipeResponseToFile * Check file contents
Derrick-MUGISHA
pushed a commit
to Derrick-MUGISHA/toolkit
that referenced
this pull request
Oct 12, 2026
…#651) * Remove spyon, use readable stream to test pipeResponseToFile * Check file contents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing
jest.spyOn(DownloadHttpClient.prototype, 'pipeResponseToFile')from the download artifact tests, and using a readable stream object to testpipeResponseToFile. Also verifying the destination file size on disk.This is set up for a follow-up PR with new test cases for truncated responses, #652.