Repository navigation
artifact: honor Retry-After on HTTP 429 and prepare 6.3.0 - #2534
Merged
tunc-d merged 2 commits intoOct 6, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No blocking issues were identified, and all 21 current-head checks passed, including the build that failed on the superseded PR.
Review effort: Balanced
Findings: None
What changed in this PR
Improves @actions/artifact retry handling for rate-limited requests and prepares version 6.3.0 without dependency changes.
Changes:
- Honors positive integer
Retry-Aftervalues on HTTP 429. - Raises initial fallback waits to 8 seconds and caps accumulated retry sleep at 120 seconds, with boundary tests.
- Updates release notes and package version metadata.
| File | Description |
|---|---|
| packages/artifact/src/internal/shared/artifact-twirp-client.ts | Adds header-aware retries and accumulated-sleep limits. |
| packages/artifact/RELEASES.md | Documents 6.3.0 retry changes. |
| packages/artifact/package.json | Sets version to 6.3.0. |
| packages/artifact/package-lock.json | Synchronizes package version metadata. |
| packages/artifact/__tests__/artifact-http-client.test.ts | Tests header parsing, fallback waits, and retry limits. |
Files not reviewed (1)
- packages/artifact/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
GhadimiR
approved these changes
Oct 6, 2026
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces closed #2498, reapplied onto current
actions/toolkit:mainwithout the superseded dependency/release history.Retry-Afterseconds only on HTTP 429, reading the header before body parsing. Missing, zero, negative, fractional, HTTP-date, or malformed values fall back to exponential backoff.@actions/artifact6.3.0 with its manifest, npm-generated lockfile, and release notes. The dependency graph is unchanged; no audit fixes or other package releases are included.Local validation: all 166 artifact tests, all package builds, targeted lint/format, packed entry points/declarations/version helper, root production audit, and all nine packages covered by the CI audit script passed. An additional audit of unchanged
attestdependencies found existing advisories;attesthas noaudit-moderatescript and is not part of that CI audit job.Release preparation only: per docs/release.md and the Publish NPM workflow, a maintainer must publish after merge with
package=artifact,branch=main,npm-tag=latest(test-alloptional). No publishing, manual release workflow, merge, or auto-merge has been triggered.