Repository navigation
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The dependency declarations and regenerated lockfiles consistently resolve the targeted packages to patched, Node-compatible versions.
Review effort: Balanced
Findings: None
What changed in this PR
Updates vulnerable transitive and direct dependencies so package-level npm audits pass.
Changes:
- Updates Undici across affected packages.
- Patches brace-expansion, markdown-it, minimatch, and ip-address.
- Regenerates corresponding lockfiles.
| File | Description |
|---|---|
packages/tool-cache/package.json |
Overrides Undici. |
packages/tool-cache/package-lock.json |
Locks updated Undici. |
packages/http-client/package.json |
Raises Undici minimum. |
packages/http-client/package-lock.json |
Locks updated Undici. |
packages/glob/package.json |
Updates minimatch and overrides Undici. |
packages/glob/package-lock.json |
Locks patched dependencies. |
packages/core/package.json |
Overrides Undici. |
packages/core/package-lock.json |
Locks updated Undici. |
packages/attest/package.json |
Updates Undici and overrides ip-address. |
packages/attest/package-lock.json |
Locks patched dependencies. |
packages/artifact/package.json |
Adds security-related overrides. |
packages/artifact/package-lock.json |
Locks patched transitive dependencies. |
Files not reviewed (6)
- packages/artifact/package-lock.json: Generated file
- packages/attest/package-lock.json: Generated file
- packages/core/package-lock.json: Generated file
- packages/glob/package-lock.json: Generated file
- packages/http-client/package-lock.json: Generated file
- packages/tool-cache/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
Folded into #2498 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the pre-existing
npm auditfailures that make the Audit check fail onmain.npm run audit-allinstalls and audits each package separately, so rootoverridesdon't apply. Overrides are declared in each affected package's ownpackage.json.npm install; no hand edits. Each lockfile diff only moves the targeted packages.Advisories fixed
http-clientundici^6.23.0→^6.28.1coreoverrides.undici: ^6.28.1@actions/http-client, which declares^6.23.0)http-clienttool-cacheoverrides.undici: ^6.28.1http-client, plus GHSA-3wwx-pv8p-q78vglobminimatch^10.2.5→^10.2.6;overrides:undici: ^6.28.1,brace-expansion: ^5.0.12http-client; brace-expansion: GHSA-mh99-v99m-4gvg, GHSA-rgw5-rvv9-x895, GHSA-q2hr-2g5m-vwhr, GHSA-qhr7-859c-m2p7, GHSA-6j4f-fj2g-mc7partifactoverrides:brace-expansion@^2: ^2.1.7,brace-expansion@^5: ^5.0.12,undici: ^6.28.1,markdown-it: ^14.3.1(existing overrides kept)attestundici^6.23.0→^6.28.1;overrides.ip-address: ^10.7.1cache,github,execandioare already clean onmainand are unchanged.Not addressed
attest:@sigstore/coreGHSA-jfc7-64v2-mr8c (moderate, via@sigstore/sign) needs a new major of@sigstore/sign, so it's out of scope here.attesthas noaudit-moderatescript, so it isn't part ofaudit-all.attest:brace-expansion2.x (GHSA-6j4f-fj2g-mc7p, GHSA-q2hr-2g5m-vwhr, GHSA-qhr7-859c-m2p7) is left for a follow-up.Supersedes Dependabot #2472 (open) and #2471 / #2473 (closed).