Repository navigation
refactor: Use early return pattern to avoid nested conditions - #302
Merged
dmitry-shibanov merged 2 commits intoDec 16, 2022
Merged
Conversation
Signed-off-by: jongwooo <jongwooo.han@gmail.com>
Contributor
|
hi @jongwooo again :D thank you for the PR. We will take a look at it |
This was referenced Dec 12, 2022
e-korolevskii
approved these changes
Dec 12, 2022
marko-zivic-93
approved these changes
Dec 15, 2022
Signed-off-by: jongwooo <jongwooo.han@gmail.com>
MaksimZhukov
approved these changes
Dec 15, 2022
dmitry-shibanov
approved these changes
Dec 16, 2022
adilhusain-s
pushed a commit
to adilhusain-s/setup-go
that referenced
this pull request
Feb 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jongwooo jongwooo.han@gmail.com
Issue #297
Description
Return early is the way of writing functions or methods so that the expected positive result is returned at the end of the function and the rest of the code terminates the execution (by returning or throwing an exception) when conditions are not met.
See actions/cache#1012, actions/setup-node#639
In
cache-utils.ts:AS-IS
TO-BE
Check list: