Repository navigation
fix(experiments): harden optional Python experiment lifecycle - #113
Conversation
- record geometry parameters for every initializer optimization run - isolate initializer and Comet boundaries from import-time behavior - close each Comet experiment after successful or failed execution Fixes #107
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughThe initializer optimization script now uses injected experiment, runner, and plotting interfaces, centralizes parameter pairs, records geometry inputs, and guarantees experiment finalization. New tests cover import safety, parameter logging, and cleanup on initializer failure. ChangesInitializer sweep refactor
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant _run_experiments
participant _run_parameter_sweep
participant initializer_runner
participant _Plotter
_run_experiments->>_run_parameter_sweep: provide experiment and runner factories
_run_parameter_sweep->>initializer_runner: execute initializer command
initializer_runner-->>_run_parameter_sweep: return initializer output
_run_parameter_sweep->>_Plotter: plot and log figures
_run_parameter_sweep->>_run_parameter_sweep: end experiment
Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Fixes #107
Summary by CodeRabbit
Refactor
Testing