Repository navigation
StrFormat: honor zero padding in slow scientific conversions - #2195
Closed
vera-rubin wants to merge 1 commit into
Closed
vera-rubin wants to merge 1 commit into
vera-rubin wants to merge 1 commit into
Conversation
mkruskal-google
approved these changes
Oct 15, 2026
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 19, 2026
Imported from GitHub PR #2195 Slow scientific `%e` and `%g` conversions dropped zero padding: `%010.0e` and `%010.1g` returned `3e+38` instead of `000003e+38` for `0x1p128`. Both emitters now append the computed zeros after any sign. The regression covers both exponent signs, positive and negative values, lowercase and uppercase conversions, sign flags, and alternate form. It fails before and passes after the fix. All eight existing str_format test targets pass in both runs with GCC 13.3, C++17, and CMake Release. Fixes #2194 Merge 7429268 into d522178 Merging this change closes #2195 PiperOrigin-RevId: 999151724
copybara-service Bot
pushed a commit
that referenced
this pull request
Oct 19, 2026
Imported from GitHub PR #2195 Slow scientific `%e` and `%g` conversions dropped zero padding: `%010.0e` and `%010.1g` returned `3e+38` instead of `000003e+38` for `0x1p128`. Both emitters now append the computed zeros after any sign. The regression covers both exponent signs, positive and negative values, lowercase and uppercase conversions, sign flags, and alternate form. It fails before and passes after the fix. All eight existing str_format test targets pass in both runs with GCC 13.3, C++17, and CMake Release. Fixes #2194 Merge 7429268 into d522178 Merging this change closes #2195 PiperOrigin-RevId: 999151724
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slow scientific
%eand%gconversions dropped zero padding:%010.0eand%010.1greturned3e+38instead of000003e+38for0x1p128.Both emitters now append the computed zeros after any sign.
The regression covers both exponent signs, positive and negative values, lowercase and uppercase conversions, sign flags, and alternate form. It fails before and passes after the fix. All eight existing str_format test targets pass in both runs with GCC 13.3, C++17, and CMake Release.
Fixes #2194
— ChipLab