Migrate debian importer to importer-improver model - #723
Merged
Conversation
TG1999
marked this pull request as draft
May 4, 2022 14:43
TG1999
marked this pull request as ready for review
May 5, 2022 13:37
TG1999
force-pushed
the
migrate/debian
branch
5 times, most recently
from
May 5, 2022 17:42
6225c34 to
23001d2
Compare
TG1999
force-pushed
the
migrate/debian
branch
3 times, most recently
from
May 6, 2022 11:43
2b69232 to
b7fc24d
Compare
pombredanne
requested changes
May 10, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Some quick comments for your review!
TG1999
force-pushed
the
migrate/debian
branch
2 times, most recently
from
May 11, 2022 12:09
e5655dd to
de0682b
Compare
pombredanne
requested changes
May 13, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks! here are few comments for your consideration.
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Contributor
Author
|
@pombredanne addressed all comments on this PR, please let me know if this looks good |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com